Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Testable Migrations #42

Merged
merged 2 commits into from
Jan 23, 2022
Merged

feat: Testable Migrations #42

merged 2 commits into from
Jan 23, 2022

Conversation

disq
Copy link
Member

@disq disq commented Jan 19, 2022

Using the new version 4 proto and SDK.
Old migrations are no more. 🦜
Version is assumed to be v0.4.0, migrations version 1. Migration has been generated with:

go run tools/migrations/main.go -prefix 1_v0.4.0 -full 

To create a potential "upgrade" migration one needs to run:

go run tools/migrations/main.go -dsn 'THE-DSN'

and check/edit the generated unreleased_*.sql files accordingly.

Please see relevant PRs on other projects:
cloudquery/cq-provider-sdk#146
cloudquery/cloudquery#406
https://github.com/cloudquery/docs/pull/75
https://github.com/cloudquery/cq-provider-template/pull/12

@github-actions github-actions bot added the feat label Jan 19, 2022
@disq disq requested a review from roneli January 19, 2022 11:56
@disq disq changed the title feat: All migrations as files feat: Testable Migrations Jan 21, 2022
@github-actions github-actions bot added feat and removed feat labels Jan 21, 2022
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit 0fa61a0 into main Jan 23, 2022
@roneli roneli deleted the feat/all-migrations-as-files branch January 23, 2022 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants