This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
fix(testing): Don't add ignored diagnostics to errors validation #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉
Summary
Related to cloudquery/cq-provider-gcp#267.
The tests on cloudquery/cq-provider-gcp#267 are failing since we validate ignored errors.
Relevant SDK code is
cq-provider-sdk/provider/execution/execution.go
Line 412 in 849cad3
Use the following steps to ensure your PR is ready to be reviewed
go fmt
to format your code 🖊golangci-lint run --new-from-rev main
🚨 (install golangci-lint here)