Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark passwords and URIs as #[\SensitiveParameter] (PHP 8.2+) #49

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Mark passwords and URIs as #[\SensitiveParameter] (PHP 8.2+) #49

merged 1 commit into from
Sep 1, 2022

Conversation

SimonFrings
Copy link
Contributor

As @clue describes in friends-of-reactphp/mysql#162:

This changeset marks all passwords and URIs containing passwords as #[\SensitiveParameter] to avoid these parameter from potentially showing up in exception traces in PHP 8.2+. Older PHP versions are not affected by this change and continue to work as is. See also RFC: https://wiki.php.net/rfc/redact_parameters_in_back_traces

Refs #48

@clue clue added this to the v1.8.0 milestone Sep 1, 2022
clue
clue approved these changes Sep 1, 2022
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this, changes LGTM! :shipit:

@clue clue merged commit 5e4de71 into clue:1.x Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonFrings @clue