Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark passwords and URIs as #[\SensitiveParameter] (PHP 8.2+) #162

Merged

Conversation

clue
Copy link
Contributor

@clue clue commented Aug 31, 2022

This changeset marks all passwords and URIs containing passwords as #[\SensitiveParameter] to avoid these parameter from potentially showing up in exception traces in PHP 8.2+. Older PHP versions are not affected by this change and continue to work as is. See also RFC: https://wiki.php.net/rfc/redact_parameters_in_back_traces

Refs #161 and #141

@WyriHaximus WyriHaximus merged commit 60a3fae into friends-of-reactphp:0.5.x Sep 6, 2022
@clue clue deleted the sensitiveparameter branch September 7, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants