Implement liquid::parse_file(...) method #58
Conversation
| /// let output = template.render(&mut data); | ||
| /// assert_eq!(output.unwrap(), Some("Liquid! 2".to_string())); | ||
| /// ``` | ||
| pub fn parse_file(fp: &str, options: LiquidOptions) -> Result<Template> { |
There was a problem hiding this comment.
You can use AsRef to enable automatic conversion of supported types to Path, which allows for a more flexible API. Basically just copy the function signature of File::open.
|
Hey, thanks so much for contributing! This patch looks great! A note on the tests: I'm not sure Cheers! |
pop
changed the title
Implements basic expected functionality: - Takes as arument a filepath (&str) and LiquidOptions. - Returns Result<Template> Includes basics tests (extends fixtures.rs). Includes doc-string documentation. fixes cobalt-org#57
|
@johannhof I took your feedback and made the suggested changes. I had no idea that AsRef design pattern was a thing in Rust, thank's for that. I also merged my commits for a cleaner git history, hope that's okay. Let me know if you have any other notes. |
|
Looks great, thanks again! In case you're looking for more stuff to do, check out the list of missing filters (#11) 😉 |
Hey I really like your project and I'm glad to be able to contribute.
If you have any questions about what / why I did something please ask. I'm fairly new to Rust so there are a few 'decisions' which were really 'I think this is how to accomplish that thing I want to do but who knows'.
Implements basic expected functionality:
LiquidOptions.Result<Template>Includes basics tests (extends
fixtures.rs).Includes doc-string documentation.
fixes Add a from_file function #57