Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a from_file function #57

Closed
johannhof opened this issue Jul 27, 2016 · 1 comment · Fixed by #58
Closed

Add a from_file function #57

johannhof opened this issue Jul 27, 2016 · 1 comment · Fixed by #58
Labels
enhancement Improve the expected good first issue Help wanted!

Comments

@johannhof
Copy link
Contributor

Would be nice to allow loading template files directly from the file system.
@johannhof johannhof added enhancement Improve the expected good first issue Help wanted! labels Jul 27, 2016
@pop
Copy link
Contributor

pop commented Aug 14, 2016

I'm experimenting with Liquid right now and am interested in implementing this feature. Is anybody working on it?

pop added a commit to pop/liquid-rust that referenced this issue Aug 14, 2016
@pop
liquid::parse_from_file(...) method
3ed3ed3 
Implements basic expected functionality:
- Takes as arument a filepath (&str) and LiquidOptions.
- Returns Result<Template>
Includes basics tests (extends fixtures.rs).
Includes doc-string documentation.
fixes cobalt-org#57
@pop pop mentioned this issue Aug 14, 2016
Merged
pop added a commit to pop/liquid-rust that referenced this issue Aug 16, 2016
@pop
liquid::parse_file(...) method
247ca16 
Implements basic expected functionality:
- Takes as arument a filepath (&str) and LiquidOptions.
- Returns Result<Template>
Includes basics tests (extends fixtures.rs).
Includes doc-string documentation.
fixes cobalt-org#57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve the expected good first issue Help wanted!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement liquid::parse_file(...) method pop/liquid-rust
2 participants
@pop @johannhof