sql: fix formatting of import, backup and create tenant #107892
Conversation
chengxiong-ruan
requested review from
nkodali,
rhu713 and
msirek
and removed request for
a team
|
This change is |
chengxiong-ruan
requested review from
a team and
msbutler
and removed request for
nkodali,
rhu713,
msirek,
a team and
msbutler
Informs: cockroachdb#99185 This commit cherry-picked changes from cockroachdb#107723 and add fixes for formatting `EXPORT` options. Release note: None
chengxiong-ruan
force-pushed
the
0727-fix-rand-syntax-99185
branch
from
cb2c0ff
to
2468ed7
Compare
chengxiong-ruan
requested review from
jayshrivastava
and removed request for
a team and
jayshrivastava
|
@knz may I also have a review on this PR? Thanks! |
There was a problem hiding this comment.
I would like to question the wisdom of fixing the bugs on the release branch before the master branch, but that's a separate discussion. For now 
Reviewable status:
complete! 1 of 0 LGTMs obtained
Good question! The reasoning behind is that I doubted the "backportability" from the beginning when looking for fixes for the test failure for 22.2. I started looking at issues for older version because I thought some syntaxes has been fixed in newer versions and a backport of fix for newer version won't fix it in older versions. It's true for 22.2. But funny that failures in master branch turned out to be a superset of 23.1, I overlooked that for sure :( |
|
TFTR! |
|
Build failed (retrying...): |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
Informs: cockroachdb#99185 This commit cherry-picked changes from cockroachdb#107892. Release note: None Fixes: cockroachdb#108254 and cockroachdb#108233 (partially) Release justification: fixes bug with random syntax generation
Informs: cockroachdb#99185 This commit cheery-picked changes from cockroachdb#107892 Release note: None Fixes: cockroachdb#108233 Release justification: fixes bug with random syntax generation
In cockroachdb#107892, there were some tests that accidentally overwrote the "WITH" syntax to "WITH OPTIONS". Release note: none Epic: none
108708: sql: fix tests overwritten with WITH OPTIONS r=rafiss a=annrpom In #107892, there were some tests that accidentally overwrote the "WITH" syntax to "WITH OPTIONS". Release note: none Epic: none Co-authored-by: Annie Pompa <[email protected]>
Informs: #99185
This commit cherry-picked changes from #107723 and add fixes for formatting
EXPORTandCHANGEFEEDoptions.Release note: None