release-23.1: sql: fix formatting of import, backup and create tenant #107723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
chengxiong-ruan
force-pushed
the
07272023-fix-rand-syntax-gen
branch
2 times, most recently
from
e2d33db
to
d536635
Compare
chengxiong-ruan
changed the title
chengxiong-ruan
force-pushed
the
07272023-fix-rand-syntax-gen
branch
from
d536635
to
64a3614
Compare
chengxiong-ruan
changed the title
chengxiong-ruan
requested review from
nkodali,
rhu713,
rytaft and
a team
and removed request for
a team,
nkodali,
rhu713 and
rytaft
Informs: cockroachdb#99183 Similar to cockroachdb#107185, this commit wraps option formatting of import, backup and restore statement with `()`. Also wrap replcation expression with `()` in `create tenant from replication` statements. Release note: None
chengxiong-ruan
force-pushed
the
07272023-fix-rand-syntax-gen
branch
from
64a3614
to
6411f55
Compare
knz
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Reviewed 8 of 21 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! |
chengxiong-ruan
added a commit
to chengxiong-ruan/cockroach
that referenced
this pull request
Jul 31, 2023
Informs: cockroachdb#99185 This commit cherry-picked changes from cockroachdb#107723 and add fixes for formatting `EXPORT` options. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
107279: sql: remove isInternalPlanner boolean r=yuzefovich a=yuzefovich This boolean is very confusing and can mislead people, so let's remove it. It was introduced in bf9ffe9 with one specific use case in mind: lease management for user defined types when the execution flow occurs in the context of a user transaction. In that scenario, the execution engine uses the planner's `descs.Collection` when running the local plan. However, I don't see the reason why we cannot do the same thing for queries outside of the user transaction (where we have the "internal planner" object), so this commit removes that extra conditional. That said, I don't quite understand how these things work, but we can always go back to not using the planner's collection for "internal planners" (we'd name the boolean differently though) if we see any fallout. Epic: None Release note: None 107834: roachtest: require stability in rebalance by load roachtests r=andrewbaptist a=kvoli The `rebalance/by-load` roachtests collect timeseries data from the cluster. If these tests started quickly enough, no datapoints could exist which would cause a out of bounds array exception. Handle the no datapoints case, and log a message without failing the test. Informs: #107247 ---- The `rebalance/by-load` roachtests would immediately pass once the balance target was hit. However, it was possible that the cluster was only transiently balanced. Bump the timeout of all tests to be uniformly 10 minutes, from a previous 5 minutes, require that the load remains balanced for at least 1 minute to pass. Informs: #107247 Release note: None 107892: sql: fix formatting of import, backup and create tenant r=chengxiong-ruan a=chengxiong-ruan Informs: #99185 This commit cherry-picked changes from #107723 and add fixes for formatting `EXPORT` and `CHANGEFEED` options. Release note: None 107955: roachtest: increase the concurrency for gracefuldraining r=kvoli a=andrewbaptist This set of commits changes gracefuldraining to use the `measureQPS` method instead of looking at the stats from the stats database and additionally increases the concurrency so it no longer fails. Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Austen McClernon <[email protected]> Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: Andrew Baptist <[email protected]>
mgartner
pushed a commit
to mgartner/cockroach
that referenced
this pull request
Aug 28, 2023
Informs: cockroachdb#99185 This commit cherry-picked changes from cockroachdb#107723 and add fixes for formatting `EXPORT` options. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs: #99183
Similar to #107185, this commit wraps option formatting of import, backup and restore statement with
(). Also wrap replcation expression with()increate tenant from replicationstatements.Release note: None
Release justification: fix syntax formatting for more stable random syntax generation test.