multiregionccl: improve and deflake TestMultiRegionDataDriven #86339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
|
TFTR! bors r=ajwerner |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like. |
This patch switches to printing the entire trace instead of an opaque failure if the trace analysis does not conform to the expected output. We also deflake this test. The framework allows for tests to express an expected leaseholder and wait for these changes to apply. Given the test cluster interface, the only claim that can be made here is that the outgoing leaseholder has applied the lease transfer. Other replicas may still be operating under a stale view of the lease. The "served via follower read" test output line is contingent on the serving replicas view of the lease. I think this was leading to some (but maybe not all) flakes we've seen sporadically. To get around this, we now wait for all replicas to have the same view of the leaseholder when waiting for zone config changes to apply. Release justification: non production code change Release note: None
arulajmani
force-pushed
the
multi-region-data-driven-test
branch
from
d4706fd
to
e65b3ca
Compare
|
bors r=ajwerner |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #77908
fixes #80837
This patch switches to printing the entire trace instead of an opaque
failure if the trace analysis does not conform to the expected output.
We also deflake this test. The framework allows for tests to express
an expected leaseholder and wait for these changes to apply. Given the
test cluster interface, the only claim that can be made here is that
the outgoing leaseholder has applied the lease transfer. Other replicas
may still be operating under a stale view of the lease. The
"served via follower read" test output line is contingent on the serving
replicas view of the lease. I think this was leading to some (but maybe
not all) flakes we've seen sporadically. To get around this, we now wait
for all replicas to have the same view of the leaseholder when waiting
for zone config changes to apply.
Release justification: non production code change
Release note: None