Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiregionccl: improve and deflake TestMultiRegionDataDriven #86339

Merged
merged 1 commit into from
Aug 18, 2022

Commits on Aug 18, 2022

  1. multiregionccl: improve and deflake TestMultiRegionDataDriven

    This patch switches to printing the entire trace instead of an opaque
    failure if the trace analysis does not conform to the expected output.
    
    We also deflake this test. The framework allows for tests to express
    an expected leaseholder and wait for these changes to apply. Given the
    test cluster interface, the only claim that can be made here is that
    the outgoing leaseholder has applied the lease transfer. Other replicas
    may still be operating under a stale view of the lease. The
    "served via follower read" test output line is contingent on the serving
    replicas view of the lease. I think this was leading to some (but maybe
    not all) flakes we've seen sporadically. To get around this, we now wait
    for all replicas to have the same view of the leaseholder when waiting
    for zone config changes to apply.
    
    Release justification: non production code change
    Release note: None
    arulajmani committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    e65b3ca View commit details
    Browse the repository at this point in the history