Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data made optional in public API #249

Merged
merged 5 commits into from
Apr 6, 2020
Merged

data made optional in public API #249

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f21488
data is optional in BinaryHeap
Harsheet-saxena Apr 6, 2020
e8cdc3f
Update pydatastructs/trees/heaps.py
czgdp1807 Apr 6, 2020
f4a389a
Update pydatastructs/trees/tests/test_heaps.py
czgdp1807 Apr 6, 2020
3723316
diff file applied
Harsheet-saxena Apr 6, 2020
1865de4
Merge branch 'heap' of https://github.com/HarsheetKakar/pydatastructs…
Harsheet-saxena Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pydatastructs/trees/heaps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def _heapify(self, i):
else:
break

def insert(self, key, data):
def insert(self, key, data=None):
"""
Insert a new element to the heap according to heap property.

Expand Down
2 changes: 1 addition & 1 deletion pydatastructs/trees/tests/test_heaps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def test_BinaryHeap():

assert raises(IndexError, lambda: max_heap.extract())

max_heap.insert(100, 100)
max_heap.insert(100)
czgdp1807 marked this conversation as resolved.
Show resolved Hide resolved
max_heap.insert(19, 19)
max_heap.insert(36, 36)
max_heap.insert(17, 17)
Expand Down