Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid URL in user profile website during editing leads to 500 error #1169

Closed
trichoplax opened this issue Aug 7, 2023 · 1 comment
Closed
Assignees
Labels
area: ruby Changes to server-side code complexity: easy Issues that should take limited effort to resolve/fix/build. priority: high type: bug Something isn't working

Comments

@trichoplax
Copy link
Contributor

Describe the bug
If a user enters text into the "Website" input box during editing their user profile, and that text is not recognised as a valid URL, the user sees a 500 error page rather than meaningful feedback.

To Reproduce
Steps to reproduce the behavior:

  1. Go to your user profile page.
  2. Click on the "Edit" tab.
  3. Scroll down to the "Website" input box.
  4. Enter the text a" into the "Website" input box.
  5. Press "Save".
  6. See 500 error page.

Expected behavior
The user should see feedback so that they know that it was the website that was rejected. They could have changed many things at once in that edit, and the 500 error page gives no indication of which of those things was a problem.

@cellio
Copy link
Member

cellio commented Aug 11, 2023

Also, letting 500s get to the user is not good. We should either catch it and use one of those in-page error-notification popups or accept the bad text but not linkify it if it's not actually a URL. (Presumably the former, since it sounds like the server is expecting a valid URL.)

Marking this high priority because of the 500, even though it's probably infrequent.

@cellio cellio added area: html/css/js Changes to front-end code type: bug Something isn't working priority: high complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Aug 11, 2023
@Oaphi Oaphi self-assigned this Aug 23, 2023
@Oaphi Oaphi added complexity: easy Issues that should take limited effort to resolve/fix/build. area: ruby Changes to server-side code and removed complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. area: html/css/js Changes to front-end code labels Aug 23, 2023
@Taeir Taeir closed this as completed in f9ce45c Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ruby Changes to server-side code complexity: easy Issues that should take limited effort to resolve/fix/build. priority: high type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants