Fix invalid profile website URI causing a 500 error page on invalid URIs #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oaphi
added
area: ruby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor PR fixing #1169 by adding a
validate_profile_websitemethod to the users controller. The core of the issue is an unguarded attempt to parse the provided URI withURI.parse, which throws aURI::InvalidURIErroron invalid URIs. Here is a preview that everything seems to be working as expected now:Screencast.from.23.08.2023.13.31.38.webm
I opted to remove the URI from the parameters and notify the user as I believe this is not severe enough to cause other valid changes to fail.