This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
Ensure default is applied if lnd settings are not present #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
approved these changes
Mar 27, 2020
tcharding
approved these changes
Mar 27, 2020
|
bors r+ |
1 similar comment
|
bors r+ |
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Mar 27, 2020
2321: Add GitHub Action CI Workflow r=mergify[bot] a=bonomat Resolves #1407 This PR introduces GitHub Action CI: Within this PR we execute the following targets: * `make build` on MacOS * `make build` on Ubuntu * `make test` on Ubuntu * `make e2e` on Ubuntu Note: I've added a new make target `ci_gha` (CI GitHubActions) so that we can keep circleCI running in parallel for some time. Once we decide to completely get rid of CircleCI we can remove/rename this field. I'll create a follow-up ticket on this Not in this PR: * `make test` on MacOS as GitHub Action MacOS does not provide Docker. Aperantly this will be provided in the future though. If so, we can run tests on MacOS as well (see here: actions/runner-images#17 (comment)) * `make build/test` on Windows as we do not have an implementation for `lnd_default_dir()` for windows (see here: https://github.com/comit-network/comit-rs/blob/93f58a1762c7c7a8da038a1ec2f22dccea1a21cb/cnd/src/lib.rs#L108-L118). I will track this in another ticket once this PR is merged. Open TODOs: * create ticket to fix windows build for github actions: * create ticket to remove unneeded make target 2334: Ensure default is applied if lnd settings are not present r=D4nte a=D4nte The `Settings` struct need to always have a the lightning settings set even if not present in the file to allow the initialisation of a lnd connector in `main.rs`. Also, we use `reqwest` to target the lnd REST API so best to have a URL in the file to avoid conversion later down the stream. Co-authored-by: Philipp Hoenisch <[email protected]> Co-authored-by: Franck Royer <[email protected]>
Build failed (retrying...) |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Settingsstruct need to always have a the lightning settings set even if not present in the file to allow the initialisation of a lnd connector inmain.rs.Also, we use
reqwestto target the lnd REST API so best to have a URL in the file to avoid conversion later down the stream.