Add docker and docker-compose to macOS #17

kaylangan · 2019-10-04T15:01:00Z

Tool information

Tool name: Docker and docker compose
Add or update? Add
Desired version:
Approximate size:
If this is an add request:
- Brief description of tool: Used for container applications
- URL for tool's homepage: https://www.docker.com/

Virtual environments affected

Already exists on the Windows and Linux environments.

Can this tool be installed during the build?

Are you willing to submit a PR?

github-actions · 2020-02-22T03:00:55Z

This issue has not had any activity for 45 days and will be closed in 45 days if there continues to be no activity.

dmitry-shibanov · 2020-03-20T10:47:18Z

Hello, thank you for your feature request. Pull request with adding docker and docker compose was merged and change would be added in next images rollout.

2321: Add GitHub Action CI Workflow r=mergify[bot] a=bonomat Resolves #1407 This PR introduces GitHub Action CI: Within this PR we execute the following targets: * `make build` on MacOS * `make build` on Ubuntu * `make test` on Ubuntu * `make e2e` on Ubuntu Note: I've added a new make target `ci_gha` (CI GitHubActions) so that we can keep circleCI running in parallel for some time. Once we decide to completely get rid of CircleCI we can remove/rename this field. I'll create a follow-up ticket on this Not in this PR: * `make test` on MacOS as GitHub Action MacOS does not provide Docker. Aperantly this will be provided in the future though. If so, we can run tests on MacOS as well (see here: actions/runner-images#17 (comment)) * `make build/test` on Windows as we do not have an implementation for `lnd_default_dir()` for windows (see here: https://github.com/comit-network/comit-rs/blob/93f58a1762c7c7a8da038a1ec2f22dccea1a21cb/cnd/src/lib.rs#L108-L118). I will track this in another ticket once this PR is merged. Open TODOs: * create ticket to fix windows build for github actions: * create ticket to remove unneeded make target 2334: Ensure default is applied if lnd settings are not present r=D4nte a=D4nte The `Settings` struct need to always have a the lightning settings set even if not present in the file to allow the initialisation of a lnd connector in `main.rs`. Also, we use `reqwest` to target the lnd REST API so best to have a URL in the file to avoid conversion later down the stream. Co-authored-by: Philipp Hoenisch <[email protected]> Co-authored-by: Franck Royer <[email protected]>

2321: Add GitHub Action CI Workflow r=mergify[bot] a=bonomat Resolves #1407 This PR introduces GitHub Action CI: Within this PR we execute the following targets: * `make build` on MacOS * `make build` on Ubuntu * `make test` on Ubuntu * `make e2e` on Ubuntu Note: I've added a new make target `ci_gha` (CI GitHubActions) so that we can keep circleCI running in parallel for some time. Once we decide to completely get rid of CircleCI we can remove/rename this field. I'll create a follow-up ticket on this Not in this PR: * `make test` on MacOS as GitHub Action MacOS does not provide Docker. Aperantly this will be provided in the future though. If so, we can run tests on MacOS as well (see here: actions/runner-images#17 (comment)) * `make build/test` on Windows as we do not have an implementation for `lnd_default_dir()` for windows (see here: https://github.com/comit-network/comit-rs/blob/93f58a1762c7c7a8da038a1ec2f22dccea1a21cb/cnd/src/lib.rs#L108-L118). I will track this in another ticket once this PR is merged. Open TODOs: * create ticket to fix windows build for github actions: * create ticket to remove unneeded make target Co-authored-by: Philipp Hoenisch <[email protected]>

dmitry-shibanov · 2020-03-27T09:33:50Z

Hello, docker, docker-machine and docker-compose were added to image. If you have any concerns please feel free to reopen the issue.

thomaseizinger · 2020-03-30T06:17:41Z

Is there anything that needs to be done for docker to be started? Our tests fail with an error from the docker CLI:

https://github.com/comit-network/comit-rs/pull/2345/checks?check_run_id=544450918#step:8:177

dmitry-shibanov · 2020-04-01T06:43:21Z

Hello @thomaseizinger, thank you for your response. I have confirmed issue and looking into it

actions/runner-images#17 (comment)

This commit improves multiple aspects of Docker builds: - Enable artifact output validation for Dockerfile. - Correct the path references in Dockerfile for the distribution directory. - Add Dockerfile specific indentation rules to `.editorconfig`. - Use `npm run install-deps` for dependency installation, enhancing build reliability. - Add automation script `verify-web-server-status.js` to verify running web server on given URL. - Introduce automated build verification for Dockerfile: - On macOS, install Docker with colima as the container runtime because default agents do not include Docker and Docker runtime is not installed due to licensing issues (see actions/runner-images#17). - On Windows, there's no Linux container support (actions/runner#904, actions/runner-images#1143), so keep the checks for macOS and Ubuntu only.

Python 3.7 and earlier reached EOL earlier this year, and many tools/libraries have stopped supporting those runtimes. Continuing to support an old runtime will be near impossible due to dependency hell. It is therefore only wise to follow suit. Dependencies have been upgraded, but no other changes were required in this project; API and ABI compatibility is maintained in this version. Most of the changes were in the key dependency `eds4jinja2`, so all benefits have been derived transitively. Like `eds4jinja2`, Python versions 3.8 and 3.11 are supported and tested for. Unlike `eds4jinja2`, support for Windows and Mac OS cannot be tested due to unavailability of or problems with `docker{-compose}` on those platforms. Cross-platform commitment for this project therefore remains informal. Additionally, license has been changed from GPL to Apache. References: - actions/runner#904 - actions/runner-images#17 (comment)

This commit improves multiple aspects of Docker builds: - Enable artifact output validation for Dockerfile. - Correct the path references in Dockerfile for the distribution directory. - Add Dockerfile specific indentation rules to `.editorconfig`. - Use `npm run install-deps` for dependency installation, enhancing build reliability. - Add automation script `verify-web-server-status.js` to verify running web server on given URL. - Introduce automated build verification for Dockerfile: - On macOS, install Docker with colima as the container runtime because default agents do not include Docker and Docker runtime is not installed due to licensing issues (see actions/runner-images#17). - On Windows, there's no Linux container support (actions/runner#904, actions/runner-images#1143), so keep the checks for macOS and Ubuntu only.

…ctions/runner-images#17

Luc45 · 2024-02-29T12:50:18Z

As mentioned before, Docker in Mac images aren't available due to licensing issues, and probably never will.

I've studied the code of https://github.com/douglascamata/setup-docker-macos-action and this seems the way to go if you need Docker AND docker compose.

My only problem is that the performance inside the docker container is very bad, I couldn't extract a 25mb zip in 5 minutes.

* Matrix the AutoGPT Python CI's `test` job across Ubuntu, macOS and Windows - Set up MinIO in a step rather than specifying it under `jobs[test].services`, because services are only supported on Linux runners - Add Windows version of step to install Poetry - Add macOS compatibility patches to 'Install Poetry (Unix)' and `setup_git_auth` steps **Caveats:** - **No Docker on macOS or Windows** * Windows comes with Docker but only supports running Windows containers, while we're mainly interested in using Linux containers for code execution and/or running auxiliary services. * [The macOS runner doesn't come with Docker](actions/runner-images#17). Setting it up is possible but takes ~3-4 minutes, and the performance of the Colima engine is poor: a `docker pull` that takes 2 seconds on Linux takes 45 seconds on macOS. - **No S3 service available on Windows** It seems that running a background process [isn't possible on Windows](actions/runner#598 (comment)), and neither is running Linux-based Docker containers. * Add `autogpt-agent` and OS-specific flags to Codecov upload step * Improve caching of Python dependencies in CI by changing the cache key - Include hash of `poetry.lock` instead of `pyproject.toml` in key - Remove date component from key; it was included to avoid getting stuck to old cached versions of packages when we were still using `requirements.txt`. With `poetry.lock` that is no longer a concern. * Fix skip check in test_s3_file_storage.py

Switch to a different action to install docker on Mac OS, the current one seems to be problematic. https://github.com/marketplace/actions/setup-docker-on-macos Useful references about the issue: actions/runner-images#17 docker-practice/actions-setup-docker#29 Signed-off-by: Diego Rondini <[email protected]>

jjangga0214 mentioned this issue Nov 15, 2019

Just use VM, not docker abinoda/slack-action#10

Open

github-actions bot added the no-issue-activity label Feb 22, 2020

miketimofeev added Area: Containers enhancement New feature or request needs triage OS: macOS and removed no-issue-activity labels Feb 24, 2020

miketimofeev assigned alepauly and thejoebourneidentity Feb 24, 2020

alepauly unassigned alepauly and thejoebourneidentity Mar 17, 2020

alepauly removed the needs triage label Mar 17, 2020

maxim-lobanov assigned dmitry-shibanov Mar 19, 2020

dmitry-shibanov added the in development label Mar 19, 2020

dmitry-shibanov added awaiting-deployment Code complete; awaiting deployment and/or deployment in progress and removed in development labels Mar 20, 2020

thomaseizinger mentioned this issue Mar 25, 2020

Migrate build process from CircleCI to GitHub actions comit-network/comit-rs#1407

Closed

bonomat mentioned this issue Mar 26, 2020

Add GitHub Action CI Workflow comit-network/comit-rs#2321

Merged

dmitry-shibanov closed this as completed Mar 27, 2020

dmitry-shibanov removed the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Mar 27, 2020

bonomat mentioned this issue Mar 30, 2020

Run tests on MacOS in GitHub Actions comit-network/comit-rs#2345

Closed

dmitry-shibanov reopened this Apr 1, 2020

dmitry-shibanov added the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Apr 8, 2020

Athena-angel added a commit to Athena-angel/image-background-remove-tool that referenced this issue May 23, 2023

Removed Mac OS from docker workflow, since actions/runner-images#17

e70a1d2

vermeulendivan mentioned this issue May 23, 2023

Investigation on Github actions tests runs on Windows and MacOS ConservationInternational/cplus-plugin#51

Open

jace added a commit to hasgeek/funnel that referenced this issue Jun 1, 2023

Install Docker on macOS

397831e

actions/runner-images#17 (comment)

berviantoleo mentioned this issue Aug 1, 2023

Possibility of MacOs & Windows Runner in Github Action to Run the Jobs ash-sxn/GSoC-2023-docker-based-quickstart#148

Closed

melotic mentioned this issue Aug 31, 2023

ci(build): build on windows and linux microsoft/component-detection#760

Merged

Kurt-von-Laven mentioned this issue Sep 21, 2023

Problem: macOS doesn't have /usr/bin/bash ScribeMD/docker-cache#306

Closed

adeebshihadeh mentioned this issue Sep 25, 2023

devcontainer: fix display override commaai/openpilot#30041

Merged

schivmeister mentioned this issue Oct 30, 2023

New version 0.3.0, dropping support for Python <= 3.7 meaningfy-ws/rdf-fingerprinter#31

Merged

wahani mentioned this issue Nov 29, 2023

Automate integration tests using GitHub Actions INWTlab/r-kafka#3

Closed

Blacksmoke16 mentioned this issue Nov 30, 2023

Run PG service as part of test CI job athena-framework/demo#2

Merged

NeetishPathak added a commit to NeetishPathak/junodb that referenced this issue Dec 5, 2023

Comment out macos-latest docker build, facing docker issue on image a…

7f288b4

…ctions/runner-images#17

NeetishPathak mentioned this issue Dec 5, 2023

Comment out macos-latest docker build, facing docker issue on image h… paypal/junodb#166

Merged

ArneTR mentioned this issue Jan 12, 2024

Enable testing on Mac green-coding-solutions/green-metrics-tool#621

Open

Kyle-Verhoog mentioned this issue Feb 17, 2024

Run macOS container tests DataDog/dd-apm-test-agent#174

Draft

musse mentioned this issue Feb 20, 2024

add the ability to download kind/kubectl on macOS GHA runners helm/kind-action#89

Closed

matmair mentioned this issue Mar 4, 2024

[Docker] Image takes ages to build inventree/InvenTree#6618

Open

Pwuts mentioned this issue Mar 21, 2024

ci(agent): Matrix CI tests across Linux, macOS and Windows Significant-Gravitas/AutoGPT#7029

Merged

9 tasks

soulgalore mentioned this issue Apr 2, 2024

Run test on Mac M1. wikimedia/pixel#261

Closed

karl-johan-grahn mentioned this issue Apr 5, 2024

PDF font embedding issue stakater-ab/.github#27

Merged

rwaight mentioned this issue Apr 30, 2024

What does "Container action is only supported on Linux" mean? chuhlomin/render-template#18

Open

idea404 mentioned this issue May 23, 2024

fix(devnet0): fix anvil error and introduce cli cmd tests omni-network/omni#1103

Closed

jameslamb mentioned this issue Jul 8, 2024

[ci] restore aarch64 linux builds (fixes #6509) microsoft/LightGBM#6527

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add docker and docker-compose to macOS #17

Add docker and docker-compose to macOS #17

kaylangan commented Oct 4, 2019 •

edited by alepauly

Loading

github-actions bot commented Feb 22, 2020

dmitry-shibanov commented Mar 20, 2020 •

edited

Loading

dmitry-shibanov commented Mar 27, 2020

thomaseizinger commented Mar 30, 2020

dmitry-shibanov commented Apr 1, 2020

Luc45 commented Feb 29, 2024 •

edited

Loading

Add docker and docker-compose to macOS #17

Add docker and docker-compose to macOS #17

Comments

kaylangan commented Oct 4, 2019 • edited by alepauly Loading

github-actions bot commented Feb 22, 2020

dmitry-shibanov commented Mar 20, 2020 • edited Loading

dmitry-shibanov commented Mar 27, 2020

thomaseizinger commented Mar 30, 2020

dmitry-shibanov commented Apr 1, 2020

Luc45 commented Feb 29, 2024 • edited Loading

kaylangan commented Oct 4, 2019 •

edited by alepauly

Loading

dmitry-shibanov commented Mar 20, 2020 •

edited

Loading

Luc45 commented Feb 29, 2024 •

edited

Loading