devcontainer: fix display override #30041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnewb1
approved these changes
Sep 25, 2023
|
I looked into testing the devcontainer on mac in CI, and it doesn't look super easy because the CI macs don't have docker desktop, but it would be nice if we could test that |
|
Some info here: actions/runner-images#17 |
|
yeah, we would need to install it ourselves. Also nested-virtualization support might be needed, since docker is using VM under the hood on macos, not sure if thats enabled (x86 might be fine, but M1 does not support it - which might cause problems in the future once GH adds these runners) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues introduced by #29704