Add extension point allowing writing up a job script file for tool commands. #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For runtime modification based on hints.
…ing job script extension.
mr-c
reviewed
Oct 20, 2016
| job_dir=None, | ||
| build_job_script=None, | ||
| ): | ||
| # type: (List[str], Text, Text, Text, Union[MutableMapping[Text, Text], MutableMapping[str, str]], Text, Text, Callable[[List[str]], Text]) -> int |
There was a problem hiding this comment.
Good news, multline Py2 annotations are now supported by mypy: http://mypy.readthedocs.io/en/latest/python2.html#multi-line-python-2-function-annotations
There was a problem hiding this comment.
Pushed a fix for this with 879c254.
There was a problem hiding this comment.
Coo'. My comment wasn't meant as a nag, just a FYI :-)
Thanks to suggestion by @mr-c (common-workflow-language#212 (review)).
qiukunlong
pushed a commit
to qiukunlong/cwltool
that referenced
this pull request
Mar 25, 2017
…language/cwl-runner-interface Initial description of cwl-runner interface
qiukunlong
pushed a commit
to qiukunlong/cwltool
that referenced
this pull request
Mar 25, 2017
d1d53b3 Merge pull request common-workflow-language#227 from common-workflow-language/stderr 0b987d3 add test 71e9b3d add stderr object 347c28e Merge pull request common-workflow-language#212 from common-workflow-language/cwl-runner-interface f36f52f Merge pull request common-workflow-language#219 from denis-yuen/patch-1 11b45b5 Merge pull request common-workflow-language#224 from common-workflow-language/jenkins-link b4d790d Backport fixes to draft-3 1ea9a5c add jenkins link 180a21e Corrections and test data 28f64f0 clarify description d791500 add output stanza, fix syntax ee0bea3 add descriptions 04dfbf0 toolfile is optional b1e740e bind and order the tool and jobfiles 81bd8de description c7a2bf1 move to a better location 979453a initial description of cwl-runner interface 5316da0 Add missing files for site generation. 31fbb76 Fix site generation workflows to specify draft-3 cff09a0 Add link to latest User Guide on front page 53b2ad7 Merge pull request common-workflow-language#200 from common-workflow-language/draft-4 089fbd7 start documenting the draft-4 changes git-subtree-dir: cwltool/schemas git-subtree-split: d1d53b3
qiukunlong
pushed a commit
to qiukunlong/cwltool
that referenced
this pull request
Mar 25, 2017
a2263a9 Make path/listing optional (sort of). de7cb76 Add listing to directory type 57a5bc8 Fix last test using "args" 3cc79d2 Port draft-3 changes to command line generation tests to draft-4. f2a18c3 Add missing args.py used by draft-3 tests. ac17f5d Port draft-2 changes to command line generation tests to draft-3. ddf417b Command line generation tests now work by executing a small script that copies the command line to the output. Allows cwl-runner implementations to drop the --conformance-test code path. c4cecad Merge pull request common-workflow-language#228 from common-workflow-language/scoped-ref-and-typedsl d1d53b3 Merge pull request common-workflow-language#227 from common-workflow-language/stderr 0b987d3 add test 71e9b3d add stderr object 347c28e Merge pull request common-workflow-language#212 from common-workflow-language/cwl-runner-interface 28f64f0 clarify description d791500 add output stanza, fix syntax ee0bea3 add descriptions 04dfbf0 toolfile is optional b1e740e bind and order the tool and jobfiles 81bd8de description c7a2bf1 move to a better location 979453a initial description of cwl-runner interface git-subtree-dir: cwltool/schemas git-subtree-split: a2263a9
qiukunlong
pushed a commit
to qiukunlong/cwltool
that referenced
this pull request
Mar 25, 2017
0c275b4 clarify that outputBinding must not be set c30b79f finish restoring allowable types for parameters 06c9ba7 Merge pull request common-workflow-language#230 from common-workflow-language/stderr-out-types cbd7bc2 only allow use of stderr/stdout shortcuts as types for the Outputs. Better place the docs 0ba703d jsonldPredicate did it! a5a7516 nope, use an enum instead 24a611d use long ids? 52f6411 extend doc to stderr psuedotype 9d0fbe0 initial stdout & stderr shortcut support 392be2f fixing site build? 57a5bc8 Fix last test using "args" 3cc79d2 Port draft-3 changes to command line generation tests to draft-4. f2a18c3 Add missing args.py used by draft-3 tests. ac17f5d Port draft-2 changes to command line generation tests to draft-3. ddf417b Command line generation tests now work by executing a small script that copies the command line to the output. Allows cwl-runner implementations to drop the --conformance-test code path. c4cecad Merge pull request common-workflow-language#228 from common-workflow-language/scoped-ref-and-typedsl d1d53b3 Merge pull request common-workflow-language#227 from common-workflow-language/stderr 0b987d3 add test 71e9b3d add stderr object 347c28e Merge pull request common-workflow-language#212 from common-workflow-language/cwl-runner-interface 28f64f0 clarify description d791500 add output stanza, fix syntax ee0bea3 add descriptions 04dfbf0 toolfile is optional b1e740e bind and order the tool and jobfiles 81bd8de description c7a2bf1 move to a better location 979453a initial description of cwl-runner interface git-subtree-dir: cwltool/schemas git-subtree-split: 0c275b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #93.