Add tllist #10763
Merged
Add tllist #10763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
This was referenced May 12, 2022
Closed
This comment has been minimized.
This comment has been minimized.
SSE4
previously approved these changes
May 12, 2022
SpaceIm
reviewed
May 12, 2022
recipes/tllist/all/conanfile.py
Outdated
Comment on lines
24
to
26
| def validate(self): | ||
| if self.settings.os != "Linux": | ||
| raise ConanInvalidConfiguration("Only Linux supported") |
There was a problem hiding this comment.
What is specific to Linux in this header? It works like a charm on macOS. I guess also on Windows.
SpaceIm
suggested changes
May 12, 2022
Co-authored-by: SpaceIm <[email protected]>
Co-authored-by: SpaceIm <[email protected]>
danimtb
commented
May 13, 2022
danimtb
commented
May 13, 2022
SpaceIm
reviewed
May 13, 2022
Co-authored-by: SpaceIm <[email protected]>
SpaceIm
previously approved these changes
May 13, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danimtb
commented
May 17, 2022
danimtb
commented
May 17, 2022
SpaceIm
reviewed
May 17, 2022
recipes/tllist/all/conanfile.py
Outdated
Comment on lines
22
to
24
| # FIXME: Fails in test_pacakge with the Windows configuration | ||
| if self.settings.os == "Windows": | ||
| raise ConanInvalidConfiguration("Windows not supported") |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uilianries
previously approved these changes
May 18, 2022
SpaceIm
reviewed
May 18, 2022
| @@ -0,0 +1,40 @@ | |||
| from conan import ConanFile | |||
There was a problem hiding this comment.
what is the requirement in terms of conan version?
There was a problem hiding this comment.
https://github.com/conan-io/conan/releases/tag/1.43.0 from 1.43.0
I am updating the required version right now 🏃 Thanks! 🦅 👁️
danimtb
commented
May 18, 2022
SpaceIm
reviewed
May 18, 2022
This comment has been minimized.
This comment has been minimized.
Co-authored-by: SpaceIm <[email protected]>
SpaceIm
approved these changes
May 19, 2022
uilianries
approved these changes
May 19, 2022
|
All green in build 14 (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #8588 and the changes proposed in the reviews of such PR (including aacebedo#1)
closes #8588