Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tllist library #8588

Closed
wants to merge 1 commit into from
Closed

add tllist library #8588

wants to merge 1 commit into from

Conversation

aacebedo
Copy link
Contributor

Specify library name and version: tllist/1.0.5

Not the author of the library but a project I am working on needs it.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@aacebedo
Copy link
Contributor Author

Sadly I do not have access to logs :( Don't know what is happening.
Conan center hooks are okay locally

@conan-center-bot

This comment has been minimized.

@jgsogo
Copy link
Contributor

jgsogo commented Dec 31, 2021

Hi! This is failing at the conan export "recipes/tllist/all/conanfile.py" tllist/1.0.5@ command. Let me try it locally.

@jgsogo
Copy link
Contributor

jgsogo commented Dec 31, 2021

Oh! You are requiring Conan v1.44 and we are still using 1.43.1 here in CCI

ERROR: Error loading conanfile at '/home/conan/conan-center-index/recipes/tllist/all/conanfile.py': Current Conan version (1.43.1) does not satisfy the defined one (>=1.44.0).

We should propagate this error (at this step) to the user... we try to hide everything unexpected just in case, but for sure this step can raise this way and the error needs to be in the output.

recipes/tllist/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tllist/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please, consider aacebedo#1

self.build_requires("ninja/[>=1.10.0]")

def build(self):
meson = Meson(self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meson-based test package, something unusual, but still welcomed!

settings = "os", "compiler", "build_type", "arch"

def build_requirements(self):
self.build_requires("pkgconf/[>=1.7.4]")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use version ranges, but as it's a test_package, should be harmless?

Comment on lines +30 to +33
self.build_requires("pkgconf/[>=1.7.4]")
self.build_requires("meson/[>=0.60.0]")
self.build_requires("ninja/[>=1.10.0]")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't use version ranges here

Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Apr 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Apr 30, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 6 (f19207b425f3e64a2bb83ccd0764072b6a3128f6):

  • tllist/1.0.5@:
    All packages built successfully! (All logs)

@ghost
Copy link

ghost commented May 12, 2022

I detected other pull requests that are modifying tllist/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants