Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-openmp: add versions v13, v14, v15, v16 and v17-rc4 #19857

Merged
merged 8 commits into from
Nov 13, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Sep 15, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (68a08af8aec495335a234f4c623cfc83c0610945):

  • llvm-openmp/17.0.4:
    All packages built successfully! (All logs)

  • llvm-openmp/16.0.6:
    All packages built successfully! (All logs)

  • llvm-openmp/15.0.7:
    All packages built successfully! (All logs)

  • llvm-openmp/14.0.6:
    All packages built successfully! (All logs)

  • llvm-openmp/8.0.1:
    All packages built successfully! (All logs)

  • llvm-openmp/13.0.1:
    All packages built successfully! (All logs)

  • llvm-openmp/9.0.1:
    All packages built successfully! (All logs)

  • llvm-openmp/12.0.1:
    All packages built successfully! (All logs)

  • llvm-openmp/11.1.0:
    All packages built successfully! (All logs)

  • llvm-openmp/10.0.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (68a08af8aec495335a234f4c623cfc83c0610945):

  • llvm-openmp/14.0.6:
    All packages built successfully! (All logs)

  • llvm-openmp/16.0.6:
    All packages built successfully! (All logs)

  • llvm-openmp/15.0.7:
    All packages built successfully! (All logs)

  • llvm-openmp/17.0.4:
    All packages built successfully! (All logs)

  • llvm-openmp/8.0.1:
    All packages built successfully! (All logs)

  • llvm-openmp/10.0.0:
    All packages built successfully! (All logs)

  • llvm-openmp/12.0.1:
    All packages built successfully! (All logs)

  • llvm-openmp/9.0.1:
    All packages built successfully! (All logs)

  • llvm-openmp/13.0.1:
    All packages built successfully! (All logs)

  • llvm-openmp/11.1.0:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those version? 🤔 What about adding only latest for now, then adding other in case someone asks in an issue? Remember that anything from LLVM consumes tons of resources to be built. E.g. I need 1h30 to build llvm-clang a single configuration in my machine and is not a bad a hardware at all.

@uilianries uilianries self-assigned this Nov 8, 2023
@valgur
Copy link
Contributor Author

valgur commented Nov 8, 2023

All those version? 🤔 What about adding only latest for now, then adding other in case someone asks in an issue? Remember that anything from LLVM consumes tons of resources to be built. E.g. I need 1h30 to build llvm-clang a single configuration in my machine and is not a bad a hardware at all.

@uilianries It fortunately does not depend on the core llvm components and builds in just seconds. I also thought it might be a good idea to provide all recent major versions just in case anyone wants match the OpenMP version to their Clang version for some reason.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries
Copy link
Member

I checked locally and they are really small packages.

@conan-center-bot conan-center-bot merged commit e5070e6 into conan-io:master Nov 13, 2023
58 checks passed
@marxin
Copy link

marxin commented Jan 7, 2024

@valgur : About # All versions except for v11 crash with a segfault for the simple test_package.cpp test: Have you filled an upstream issue about it? Is it something known by upstream?

@valgur
Copy link
Contributor Author

valgur commented Jan 7, 2024

@marxin No, I have not. Feel free to investigate the issue and report it upstream.

@marxin
Copy link

marxin commented Jan 9, 2024

I bet it's caused by the following hairy issue: llvm/llvm-project#49923. Apparently, the Apple interest for OpenMP on aarch64 is pretty low :/

valgur added a commit to valgur/conan-center-index that referenced this pull request Jan 18, 2024
conan-center-bot pushed a commit that referenced this pull request Jul 8, 2024
* llvm-openmp: fix missing FindOpenMP.cmake, check _OPENMP define

* llvm-openmp: improve exported compiler flags

* llvm-openmp: print runtime library info in test_package

* llvm-openmp: match the output of FindOpenMP.cmake

* llvm-openmp: add MSVC support

* llvm-openmp: mention potential cause of the armv8 Debug issues

As suggested by @marxin at #19857 (comment)

* llvm-openmp: add a comment

* llvm-openmp: move omp to a separate component

* llvm-openmp: add Conan v1 support

* llvm-openmp: drop v10 and lower

The wrong runtime library gets picked up in test_package for some reason. Don't feel like debugging it.

* llvm-openmp: patches can be dropped

* llvm-openmp: libomptarget is not available on macOS and Windows

https://github.com/llvm/llvm-project/blob/llvmorg-17.0.6/openmp/CMakeLists.txt#L103-L104

* llvm-openmp: fix CMake 3.15 incompatibility

* llvm-openmp: .get_safe("build_libomptarget")

* llvm-openmp: don't use a target for linking in the module

* llvm-openmp: restore the v11 macOS armv8 patch

* llvm-openmp: add psapi system lib dep on Windows

* llvm-openmp: OpenMP version and spec date version can be determined during packaging

Avoids a fragile compilation check during find_package().

* llvm-openmp: re-wrap description

* llvm-openmp: add v18.1.3

* llvm-openmp: print even more details in test_package

* llvm-openmp: set OpenMP version to the minimum of compiler and runtime support

* llvm-openmp: add all spec date versions

From https://github.com/Kitware/CMake/blob/master/Modules/FindOpenMP.cmake

* llvm-openmp: set shared=True by default on Windows

* llvm-openmp: force shared=True on Windows

* llvm-openmp: fix try_compile() on CXX-only projects

* llvm-openmp: bump to v18.1.6

* llvm-openmp: bump to v18.1.8

* llvm-openmp: make the wrapper slightly more robust

Based on microsoft/vcpkg#39389
valgur added a commit to valgur/conan-center-index that referenced this pull request Jul 11, 2024
@valgur valgur deleted the llvm-openmp/new-version branch August 6, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants