[llvm-openmp,openmp] add a meta-package for OpenMP #39389
Conversation
WangWeiLin-MV
added
category:new-port
* llvm-openmp: fix missing FindOpenMP.cmake, check _OPENMP define * llvm-openmp: improve exported compiler flags * llvm-openmp: print runtime library info in test_package * llvm-openmp: match the output of FindOpenMP.cmake * llvm-openmp: add MSVC support * llvm-openmp: mention potential cause of the armv8 Debug issues As suggested by @marxin at #19857 (comment) * llvm-openmp: add a comment * llvm-openmp: move omp to a separate component * llvm-openmp: add Conan v1 support * llvm-openmp: drop v10 and lower The wrong runtime library gets picked up in test_package for some reason. Don't feel like debugging it. * llvm-openmp: patches can be dropped * llvm-openmp: libomptarget is not available on macOS and Windows https://github.com/llvm/llvm-project/blob/llvmorg-17.0.6/openmp/CMakeLists.txt#L103-L104 * llvm-openmp: fix CMake 3.15 incompatibility * llvm-openmp: .get_safe("build_libomptarget") * llvm-openmp: don't use a target for linking in the module * llvm-openmp: restore the v11 macOS armv8 patch * llvm-openmp: add psapi system lib dep on Windows * llvm-openmp: OpenMP version and spec date version can be determined during packaging Avoids a fragile compilation check during find_package(). * llvm-openmp: re-wrap description * llvm-openmp: add v18.1.3 * llvm-openmp: print even more details in test_package * llvm-openmp: set OpenMP version to the minimum of compiler and runtime support * llvm-openmp: add all spec date versions From https://github.com/Kitware/CMake/blob/master/Modules/FindOpenMP.cmake * llvm-openmp: set shared=True by default on Windows * llvm-openmp: force shared=True on Windows * llvm-openmp: fix try_compile() on CXX-only projects * llvm-openmp: bump to v18.1.6 * llvm-openmp: bump to v18.1.8 * llvm-openmp: make the wrapper slightly more robust Based on microsoft/vcpkg#39389
| set(_CMAKE_MODULE_PATH "${CMAKE_MODULE_PATH}") | ||
| # if(CMAKE_CXX_COMPILER_ID MATCHES "^(Clang|AppleClang)$") | ||
| if(CMAKE_CXX_COMPILER_ID MATCHES "^(Clang|AppleClang)$") |
There was a problem hiding this comment.
so how to use it also with MSVC, if I would like to?
There should be a "bypass" variable maybe? something like "...OR Z_VCPKG_USE_LLVM_OPENMP)"
There was a problem hiding this comment.
Realistically, you should probably simply use the LLVM OpenMP implementation included with MSVC, available by setting /openmp:llvm or OpenMP_RUNTIME_MSVC=llvm in CMake.
I can add something like Z_VCPKG_OPENMP=llvm for example, but unless it's exposed as a feature of the port, the user will have to take care to either set it globally or set it in the installed config, which feels a bit fragile. And using features to implement alternatives does not work well and is strongly discouraged.
There was a problem hiding this comment.
New ports are not allowed to add wrapper files anymore, and as additional information, compiler condition is not allowed in portfile.cmake, it could be determined in the CMakeLists.txt of project.
There was a problem hiding this comment.
New ports are not allowed to add wrapper files anymore
Could you be more specific?
FindOpenMP.cmake is an official CMake Find module. That's the case where wrappers might be appropriate.
There was a problem hiding this comment.
I'm not quite sure how to modify it.
@data-queue Could you help to take a look? Thanks.
WangWeiLin-MV
added
the
info:reviewed
data-queue
added
the
requires:vcpkg-team-review
|
Hi @valgur @AugP @BillyONeal @data-queue @JavierMatosD @ras0219-msft and I discussed this PR and have some comments:
|
WangWeiLin-MV
removed
the
info:reviewed
There are many Vcpkg ports that can make use of OpenMP, but it's generally disabled by default due to the missing out-of-the-box support for Clang and AppleClang. This PR splits
llvm-openmpfromllvminto a separate port to fill that gap.Building the full
llvmport just for OpenMP would be a massive overkill (easily more than hour to build and tens of GB of build artifacts). In contrast, the OpenMP component builds in just a few seconds.I also added an
openmpmeta-package that's intended to be similar toblasandlapackones.llvm-openmpis only used for Clang and AppleClang, but is installed as a dependency for all platforms, since thesupportsexpression does not provide a way to distinguish between compilers.I placed all
llvm-openmplibraries and headers under anunofficial-llvm-openmpsubdirectory ininclude/,lib/andbin/to avoid conflicts with thellvmport and with other OpenMP implementations that look for anomp.hheader as well.I added
openmpas a dependency to thedmlcport to test it as a direct and a transitive dependency (viarabit, which depends ondmlc).find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.