-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcl: add v1.14.0, use llvm-openmp for OpenMP #22152
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I want PCL 1.14.1, and I'm really looking forward to it being merged. |
Hi @valgur is this PR still in draft? |
This comment has been minimized.
This comment has been minimized.
It should be ready to be merged. Needs a build to verify that, though. Of course, I would love to use |
This comment has been minimized.
This comment has been minimized.
We are under maintaining right now, I'll launch them manually
We have been discussing with the team and the potential risk of mixing different openMP backends and other problems we sow do not compensate the extra copy-paste code. |
Thanks, I appreciate the consideration and caution you have put into the topic with the team. The mixing of OpenMP runtimes was a valid concern for the initial compromise suggestion of defaulting to |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 18 ( An unexpected error happened and has been reported. Help is on its way! 🏇 Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 18 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
I scanned the diff against previous version and there were no changes to the list of components or their dependencies, either internal or external ones.