[ParlayHash] new recipe #22638
[ParlayHash] new recipe #22638
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@conan-io/barbarians guys could you please give me a hand with the error. Thanks |
Co-authored-by: toge <[email protected]>
This comment has been minimized.
This comment has been minimized.
…i/conan-center-index into feat/parlayhash
|
@RubenRBS Guys, please 🙏 |
|
Oops, this got miss-tagged internally so I missed it, will circle back to it tomorrow, thanks for the ping :) |
|
@fpelliccioni Please replace test_package.cpp with the following code. |
Thanks! |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: toge <[email protected]>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: toge <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
@fpelliccioni |
|
@RubenRBS @czoido |
This comment has been minimized.
This comment has been minimized.
|
@conan-io/barbarians please guys |
|
@fpelliccioni These error is caused by several temporary files in release files. (#hash_table.h#, #primitives.h#, ...) Could you please ask the author to delete the unnecessary files? |
…i/conan-center-index into feat/parlayhash
Thank you very much por your response. |
|
@fpelliccioni |
Done |
This comment has been minimized.
This comment has been minimized.
|
Hi @rturrado I've directly pushed to your branch some changes, please check them and let me know if you agree with those. I've taken the target name from https://github.com/cmuparlay/parlayhash/blob/main/examples/CMakeLists.txt#L2, but the file has been just a guess from the default name of the recipe, as upstream does not set one - I guess we could ask them what they'd prefer if you're up for it :) |
|
Weird, Conan 2 works for me in a similar configuration as the failing one in Conan 2: |
Conan v1 pipeline ❌Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hi @RubenRBS , I think you addressed me here instead of @fpelliccioni. |
|
Oops, sorry for the noise, I was juggling both PRs at once and got confused, sorry! |
|
No problem at all! |
Thanks @RubenRBS I agree with your changes! |
|
|
||
| add_executable(${PROJECT_NAME} test_package.cpp) | ||
| target_link_libraries(${PROJECT_NAME} PRIVATE parlay) | ||
| target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17) |
There was a problem hiding this comment.
| target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17) | |
| set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 17) |
Because std::result_of has been removed since C++20,
we have to specify using C++17.
It seems to be caused by lack of C++ support on older apple-clang. create package log on apple clang 15% conan create . --build=missing --version=0.1 ======== Exporting recipe to the cache ======== ======== Input profiles ======== Profile build: ======== Computing dependency graph ======== ======== Computing necessary packages ======== ======== Installing packages ======== ======== Launching test_package ======== ======== Computing dependency graph ======== ======== Computing necessary packages ======== ======== Installing packages ======== ======== Testing the package ======== ======== Testing the package: Building ======== parlayhash/0.1 (test package): Running CMake.build() ======== Testing the package: Executing test ======== |
|
At the moment seems that only works fine on Linux. We can allow just Linux
and Un further releases add the other platforms. Is this Ok for you?
…On Wed, May 8, 2024, 5:20 PM toge ***@***.***> wrote:
@fpelliccioni <https://github.com/fpelliccioni>
include/parlay_hash/parlay_hash.h:644:12: error: reference to local binding 'tag' declared in enclosing function 'parlay::parlay_hash::Find'
if (b->lv(tag)) return find_in_list(s.overflow_list(), k, f).first;
^
It seems to be caused by lack of C++ support on older apple-clang.
In my environment (apple-clang 15.0.0), it works fine.
create package log on apple clang 15
% conan create . --build=missing --version=0.1
======== Exporting recipe to the cache ========
parlayhash/0.1: Exporting package recipe:
/private/tmp/conan-center-index/recipes/parlayhash/all/conanfile.py
parlayhash/0.1: exports: File 'conandata.yml' found. Exporting it...
parlayhash/0.1: Copied 1 '.py' file: conanfile.py
parlayhash/0.1: Copied 1 '.yml' file: conandata.yml
parlayhash/0.1: Exported to cache folder:
/Users/toge/.conan2/p/parla82d380b323587/e
parlayhash/0.1: Exported: parlayhash/0.1#a628b4202745bb423098d9d8515a536c
(2024-05-08 15:09:27 UTC)
======== Input profiles ========
Profile host:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=20
compiler.libcxx=libc++
compiler.version=15
os=Macos
Profile build:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=20
compiler.libcxx=libc++
compiler.version=15
os=Macos
======== Computing dependency graph ========
Graph root
cli
Requirements
parlayhash/0.1#a628b4202745bb423098d9d8515a536c - Cache
======== Computing necessary packages ========
Requirements
parlayhash/0.1#a628b4202745bb423098d9d8515a536c:da39a3ee5e6b4b0d3255bfef95601890afd80709#27b07243cd6fffb873a6d4e40e78bd93
- Cache
======== Installing packages ========
parlayhash/0.1: Already installed! (1 of 1)
======== Launching test_package ========
======== Computing dependency graph ========
Graph root
parlayhash/0.1 (test package):
/private/tmp/conan-center-index/recipes/parlayhash/all/test_package/conanfile.py
Requirements
parlayhash/0.1#a628b4202745bb423098d9d8515a536c - Cache
======== Computing necessary packages ========
Requirements
parlayhash/0.1#a628b4202745bb423098d9d8515a536c:da39a3ee5e6b4b0d3255bfef95601890afd80709#27b07243cd6fffb873a6d4e40e78bd93
- Cache
======== Installing packages ========
parlayhash/0.1: Already installed! (1 of 1)
======== Testing the package ========
Removing previously existing 'test_package' build folder:
/private/tmp/conan-center-index/recipes/parlayhash/all/test_package/build/apple-clang-15-armv8-20-release
parlayhash/0.1 (test package): Test package build:
build/apple-clang-15-armv8-20-release
parlayhash/0.1 (test package): Test package build folder:
/private/tmp/conan-center-index/recipes/parlayhash/all/test_package/build/apple-clang-15-armv8-20-release
parlayhash/0.1 (test package): Writing generators to
/private/tmp/conan-center-index/recipes/parlayhash/all/test_package/build/apple-clang-15-armv8-20-release/generators
parlayhash/0.1 (test package): Generator 'CMakeDeps' calling 'generate()'
parlayhash/0.1 (test package): CMakeDeps necessary find_package() and
targets for your CMakeLists.txt
find_package(parlayhash)
target_link_libraries(... parlay)
parlayhash/0.1 (test package): Generator 'CMakeToolchain' calling
'generate()'
parlayhash/0.1 (test package): CMakeToolchain generated:
conan_toolchain.cmake
parlayhash/0.1 (test package): CMakeToolchain generated: CMakePresets.json
parlayhash/0.1 (test package): CMakeToolchain generated:
../../../CMakeUserPresets.json
parlayhash/0.1 (test package): Generator 'VirtualRunEnv' calling
'generate()'
parlayhash/0.1 (test package): Generating aggregated env files
parlayhash/0.1 (test package): Generated aggregated env files:
['conanrun.sh', 'conanbuild.sh']
======== Testing the package: Building ========
parlayhash/0.1 (test package): Calling build()
parlayhash/0.1 (test package): Running CMake.configure()
parlayhash/0.1 (test package): RUN: cmake -G "Unix Makefiles"
-DCMAKE_TOOLCHAIN_FILE="/private/tmp/conan-center-index/recipes/parlayhash/all/test_package/build/apple-clang-15-armv8-20-release/generators/conan_toolchain.cmake"
-DCMAKE_INSTALL_PREFIX="/private/tmp/conan-center-index/recipes/parlayhash/all/test_package"
-DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release"
"/private/tmp/conan-center-index/recipes/parlayhash/all/test_package"
-- Using Conan toolchain:
/tmp/conan-center-index/recipes/parlayhash/all/test_package/build/apple-clang-15-armv8-20-release/generators/conan_toolchain.cmake
-- Conan toolchain: C++ Standard 20 with extensions OFF
-- The CXX compiler identification is AppleClang 15.0.0.15000309
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
- skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Target declared 'parlay'
-- Configuring done
-- Generating done
-- Build files have been written to:
/tmp/conan-center-index/recipes/parlayhash/all/test_package/build/apple-clang-15-armv8-20-release
parlayhash/0.1 (test package): Running CMake.build()
parlayhash/0.1 (test package): RUN: cmake --build
"/private/tmp/conan-center-index/recipes/parlayhash/all/test_package/build/apple-clang-15-armv8-20-release"
-- -j8
[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
[100%] Linking CXX executable test_package
[100%] Built target test_package
======== Testing the package: Executing test ========
parlayhash/0.1 (test package): Running test()
parlayhash/0.1 (test package): RUN: ./test_package
value before increment: 1
value after increment: 2
size before remove: 2
size after remove: 1
—
Reply to this email directly, view it on GitHub
<#22638 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACC2E2TCY6DW24UENYZUPTZBI7CTAVCNFSM6AAAAABCWRTTF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBQHAZDQNZUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Specify library name and version: ParlayHash/0.0.2