Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ParlayHash] new recipe #22638

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions recipes/parlayhash/all/conandata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
sources:
"0.1":
url: "https://github.com/cmuparlay/parlayhash/archive/refs/tags/v0.1.tar.gz"
sha256: "63dd2680de0291c8c4440fc3364490de0ee3cdea94b02b7449900bac18d66f2f"
76 changes: 76 additions & 0 deletions recipes/parlayhash/all/conanfile.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
from conan import ConanFile
from conan.errors import ConanInvalidConfiguration
from conan.tools.files import get, copy, rm
from conan.tools.build import check_min_cppstd
from conan.tools.scm import Version
from conan.tools.layout import basic_layout
import os

required_conan_version = ">=1.53.0"


class ParlayHashConan(ConanFile):
name = "parlayhash"
description = "A Header-Only Scalable Concurrent Hash Map."
license = "MIT"
url = "https://github.com/conan-io/conan-center-index"
homepage = "https://github.com/cmuparlay/parlayhash"
topics = ("unordered_map", "hashmap", "header-only")
package_type = "header-library"
settings = "os", "arch", "compiler", "build_type"
no_copy_source = True

@property
def _minimum_cpp_standard(self):
return 17

@property
def _compilers_minimum_version(self):
return {
"Visual Studio": "15.7",
"msvc": "191",
"gcc": "7",
"clang": "7",
"apple-clang": "11",
}

def layout(self):
basic_layout(self, src_folder="src")

def package_id(self):
self.info.clear()

def requirements(self):
# TODO: Upstream mentions jemalloc in https://github.com/cmuparlay/parlayhash/blob/main/CMakeLists.txt#L45
# but it's not ported to Conan 2 yet. Add it here if needed in the future.
pass

def validate(self):
if self.settings.get_safe("compiler.cppstd"):
check_min_cppstd(self, self._minimum_cpp_standard)
minimum_version = self._compilers_minimum_version.get(str(self.settings.compiler), False)
if minimum_version and Version(self.settings.get_safe("compiler.version")) < minimum_version:
raise ConanInvalidConfiguration(f"{self.ref} requires C++{self._minimum_cpp_standard}, which your compiler does not support.")

def source(self):
get(self, **self.conan_data["sources"][self.version], strip_root=True)
rm(self, "#hash_table.h#", os.path.join(self.source_folder, "include", "parlay"))
rm(self, "#primitives.h#", os.path.join(self.source_folder, "include", "parlay"))
rm(self, ".#hash_table.h", os.path.join(self.source_folder, "include", "parlay"))

def build(self):
pass

def package(self):
copy(self, pattern="LICENSE", dst=os.path.join(self.package_folder, "licenses"), src=self.source_folder)
copy(self, pattern="*.h", dst=os.path.join(self.package_folder, "include"), src=os.path.join(self.source_folder, "include"))

def package_info(self):
self.cpp_info.bindirs = []
self.cpp_info.libdirs = []
if self.settings.os in ["Linux", "FreeBSD"]:
self.cpp_info.system_libs.append("pthread")

# This one is a best-effort guess, as the library is header-only it does not mention a target explicitly
self.cpp_info.set_property("cmake_file_name", "parlayhash")
self.cpp_info.set_property("cmake_target_name", "parlay")
9 changes: 9 additions & 0 deletions recipes/parlayhash/all/test_package/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
cmake_minimum_required(VERSION 3.15)

project(test_package LANGUAGES CXX)

find_package(parlayhash REQUIRED CONFIG)

add_executable(${PROJECT_NAME} test_package.cpp)
target_link_libraries(${PROJECT_NAME} PRIVATE parlay)
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17)
set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 17)

Because std::result_of has been removed since C++20,
we have to specify using C++17.

https://en.cppreference.com/w/cpp/types/result_of

26 changes: 26 additions & 0 deletions recipes/parlayhash/all/test_package/conanfile.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
from conan import ConanFile
from conan.tools.build import can_run
from conan.tools.cmake import cmake_layout, CMake
import os


class TestPackageConan(ConanFile):
settings = "os", "arch", "compiler", "build_type"
generators = "CMakeDeps", "CMakeToolchain", "VirtualRunEnv"
test_type = "explicit"

def requirements(self):
self.requires(self.tested_reference_str)

def layout(self):
cmake_layout(self)

def build(self):
cmake = CMake(self)
cmake.configure()
cmake.build()

def test(self):
if can_run(self):
bin_path = os.path.join(self.cpp.build.bindirs[0], "test_package")
self.run(bin_path, env="conanrun")
23 changes: 23 additions & 0 deletions recipes/parlayhash/all/test_package/test_package.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#include <iostream>
#include <string>
#include <parlay/parallel.h>
#include "parlay_hash/unordered_map.h"

using K = std::string;
using V = unsigned long;
using map_type = parlay::parlay_unordered_map<K,V>;

int main() {
map_type my_map(100);
my_map.Insert("sue", 1);
my_map.Insert("sam", 5);

std::cout << "value before increment: " << *my_map.Find("sue") << std::endl;
auto increment = [] (std::optional<V> v) -> V {return v.has_value() ? 1 + *v : 1;};
my_map.Upsert("sue", increment);
std::cout << "value after increment: " << *my_map.Find("sue") << std::endl;

std::cout << "size before remove: " << my_map.size() << std::endl;
my_map.Remove("sue");
std::cout << "size after remove: " << my_map.size() << std::endl;
}
3 changes: 3 additions & 0 deletions recipes/parlayhash/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
versions:
"0.1":
folder: all
Loading