Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pangolin: new recipe #23782

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

pangolin: new recipe #23782

wants to merge 12 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 26, 2024

Adds Pangolin: https://github.com/stevenlovegrove/Pangolin

Pangolin is a set of lightweight and portable utility libraries for prototyping 3D, numeric or video based programs and algorithms. It is used quite widely in the field of Computer Vision as a means to remove platform-specific boilerplate and make it easy to visualize data.

Packaging status

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 07b54b2
pangolin/0.9.1@#235af94f33075e9328380b27be6797c2
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpango_windowing.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 12 (ae8f455aab96ceba2061cdb35d74ae85bd1d2740):

  • pangolin/0.9.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 12 (ae8f455aab96ceba2061cdb35d74ae85bd1d2740):

  • pangolin/0.9.1:
    All packages built successfully! (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit ae8f455
pangolin/0.9.1@#280b504edc26f07ddf68fa79a2a63778
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpango_windowing.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.

@perseoGI
Copy link
Contributor

perseoGI commented Jul 5, 2024

pangolin-compilation-logs.txt

Tested at least 100 combinations with different options in macOS ARM and LGTM
Added compilation traces

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though there are excessive options available, it looks good to me

@valgur
Copy link
Contributor Author

valgur commented Sep 8, 2024

@jwillikers Would you be willing to provide the necessary second review for this PR?

if self.options.get_safe("with_wayland"):
# Wayland 1.20+ is not compatible as of v0.9.1
self.requires("wayland/1.19.0")
self.requires("wayland-protocols/1.33")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since wayland-protocols isn't a runtime dependency, most recipes incorporate it as a tool_requires. Here is where xkbcommon incorporates it. The downside to the tool_requires approach is that the same version of the protocols isn't properly propagated across dependencies, which seems like something that should be consistent across projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] pangolin/0.8
5 participants