Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib-cpp/cci.20210111 #4212

Closed
wants to merge 9 commits into from

Conversation

blackliner
Copy link
Contributor

@blackliner blackliner commented Jan 11, 2021

Specify library name and version: matplotlib-cpp/cci.20210111

Looking for feedback regarding the python 3 requirement, do we have a system package?

Requesting issue: #3033

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 11, 2021

Can't be added right now, it requires cpython recipe: #1510

@conan-center-bot

This comment has been minimized.

@blackliner
Copy link
Contributor Author

Can't be added right now, it requires cpython recipe: #1510

Don't want to start a big discussion, but can't we assume with certainty that python is available? I mean, no python, no conan?

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 11, 2021

Can't be added right now, it requires cpython recipe: #1510

Don't want to start a big discussion, but can't we assume with certainty that python is available? I mean, no python, no conan?

It depends how it was installed. python might not be available (conan windows installer for example).
Moreover:

  • consumers might be surprised to be "polluted" with numpy in their system installed python.
  • no control on python version

@blackliner
Copy link
Contributor Author

blackliner commented Jan 11, 2021

It depends how it was installed. python might not be available (conan windows installer for example).
Moreover:

  • consumers might be surprised to be "polluted" with numpy in their system installed python.

Fully agree, just curious to see if that actually works on CCI-CI 🙈

  • no control on python version

For this package, I do not really care, but I get the point, for example if you need 3.x

The PR you mentioned tries to make python available from scratch, why not start with a python/system@ package first?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Apr 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2021
@uilianries
Copy link
Member

It requires numpy first.

@stale stale bot removed the stale label Apr 7, 2021
@SpaceIm
Copy link
Contributor

SpaceIm commented Apr 7, 2021

And cpython recipe.

@blackliner
Copy link
Contributor Author

So, long story short, its currently impossible to build packages that depend on python?

Would depending on python/system be an alternative?

@stale
Copy link

stale bot commented May 8, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 8, 2021
@blackliner
Copy link
Contributor Author

@uilianries @SpaceIm : Is it possible at all to depend on python and/or numpy in the current state of the CCI? Are there any other packages that do something similar? I don't know if it makes sense to grab another copy of python and numpy for this package, I think its safe to just check if those packages exist on the users system, and error out if that is not the case.

But how should one tell this to the CCI-CI ?

@stale stale bot removed the stale label May 8, 2021
@SpaceIm
Copy link
Contributor

SpaceIm commented May 25, 2021

Currently, several recipes implicitly rely on python as a build requirement. But for matplotlib-cpp, it's worse, it's a requirement, it links to python library.

@blackliner
Copy link
Contributor Author

Currently, several recipes implicitly rely on python as a build requirement. But for matplotlib-cpp, it's worse, it's a requirement, it links to python library.

So, no luck for now?

@SpaceIm
Copy link
Contributor

SpaceIm commented May 25, 2021

Yes, "Welcome to matplotlib-cpp, possibly the simplest C++ plotting library" is not true for conan 😞

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Failure in build 11 (45185a84907529755259052bc9a3d0ea7b7de7c2):

  • matplotlib-cpp/cci.20210601@:
    CI failed to create some packages (All logs)

    Logs for packageID 5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++
    compiler.version=4.9
    os=Linux
    os_build=Linux
    
    [...]
    -- Conan: Adjusting language standard
    -- Conan: Checking correct version: 4.9
    -- Conan: C++ stdlib: libstdc++
    -- Conan: Using autogenerated Findmatplotlib-cpp.cmake
    -- Found matplotlib-cpp: cci.20210601 (found version "cci.20210601") 
    -- Found Python3: /opt/pyenv/versions/3.6.7/bin/python3.6 (found version "3.6.7") found components: Interpreter Development Development.Module Development.Embed 
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/BuildSingleReference/conan-center-index/recipes/matplotlib-cpp/all/test_package/build/dfae4d6ba682b8d9c5630c4c912db585c2a46c64
    
    ----Running------
    > cmake --build '/home/conan/w/BuildSingleReference/conan-center-index/recipes/matplotlib-cpp/all/test_package/build/dfae4d6ba682b8d9c5630c4c912db585c2a46c64' '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    [100%] Linking CXX executable bin/test_package
    [100%] Built target test_package
    matplotlib-cpp/cci.20210601 (test package): Running test()
    
    ----Running------
    > bin/test_package
    -----------------
    matplotlib-cpp/cci.20210601: WARN: Lib folder doesn't exist, can't collect libraries: /home/conan/w/BuildSingleReference/.conan/data/matplotlib-cpp/cci.20210601/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib
    WARNING: pip is being invoked by an old script wrapper. This will fail in a future version of pip.
    Please see https://github.com/pypa/pip/issues/5599 for advice on fixing the underlying issue.
    To avoid this problem you can invoke Python with '-m pip' instead of running pip directly.
    WARNING: You are using pip version 21.1.2; however, version 21.1.3 is available.
    You should consider upgrading via the '/opt/pyenv/versions/3.6.7/bin/python3.6 -m pip install --upgrade pip' command.
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    WARNING: /opt/pyenv/versions/3.6.7/lib/python3.6/site-packages/conans/client/tools/oss.py:474: UserWarning: Argument 'settings' has been deprecated, use 'conanfile' instead
      warnings.warn("Argument 'settings' has been deprecated, use 'conanfile' instead")
    
    terminate called after throwing an instance of 'std::runtime_error'
      what():  Error loading module matplotlib!
    Aborted
    ERROR: matplotlib-cpp/cci.20210601 (test package): Error in test() method, line 33
    	self.run(bin_path, run_environment=True)
    	ConanException: Error 134 while executing bin/test_package
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants