Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libigl #5542

Merged
merged 62 commits into from
Sep 10, 2021
Merged

Add libigl #5542

merged 62 commits into from
Sep 10, 2021

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented May 17, 2021

Specify library name and version: libigl/2.3.0

closes #3335


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

"ERROR: libigl/2.3.0: Error in build() method, line 86
self.copy("LICENSE.*", dst="licenses", src=self._source_subfolder)
AttributeError: 'LibiglConan' object has no attribute 'copy'"

What's wrong with this line? I have seen many similar in the other recipes, for example:
rocksdb/all/conanfile.py: self.copy("LICENSE*", dst="licenses", src=self._source_subfolder)

@SSE4
Copy link
Contributor

SSE4 commented May 17, 2021

"ERROR: libigl/2.3.0: Error in build() method, line 86
self.copy("LICENSE.*", dst="licenses", src=self._source_subfolder)
AttributeError: 'LibiglConan' object has no attribute 'copy'"

What's wrong with this line? I have seen many similar in the other recipes, for example:
rocksdb/all/conanfile.py: self.copy("LICENSE*", dst="licenses", src=self._source_subfolder)

AFAIK self.copy only allowed in certain methods, e.g. it works in package but not in build

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

Need a bit help here. Build process does not produce a lib if shared=True

@dvd0101 @scottsha

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, please, take a look on my review.

recipes/libigl/all/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/libigl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libigl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libigl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libigl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libigl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libigl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libigl/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/libigl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libigl/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

I need some help here
@dvd0101 @scottsha @uilianries @SSE4

@SSE4
Copy link
Contributor

SSE4 commented May 18, 2021

seems like upstream doesn't provide an install target, so... files have to be copied manually.

@uilianries
Copy link
Member

Weird, I can see install method for CMake: https://github.com/libigl/libigl/blob/v2.3.0/cmake/libigl.cmake#L533

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

It seems, the library behavies as a header-only if shared=true. It does not produce a lib, but it can be used.

What's the best way to avoid conan hooks?
I can for example, make the lib to be static only and remove shared flag

@SSE4 SSE4 closed this Sep 1, 2021
@SSE4 SSE4 reopened this Sep 1, 2021
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

I have submitted an issue about x86 and arm builds upstream:
libigl/libigl#1888

@conan-center-bot

This comment has been minimized.

@jgsogo jgsogo added the infrastructure Waiting on tools or services belonging to the infra label Sep 3, 2021
@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

@jgsogo , what's wrong with the CI?
Is it the same error, as on Windows? There is not enough RAM and we have disabled Win build

@jgsogo
Copy link
Contributor

jgsogo commented Sep 7, 2021

I think the problem is with RAM memory on Linux PODs. Did anyone try it locally with different memory limits? I think we have 6Gb available now.

@AndreyMlashkin
Copy link
Contributor Author

I have started docker with
docker run -it --rm --memory="6g" conanio/gcc10
and it went through.
I am using windows, but it should not matter in this case

@jgsogo
Copy link
Contributor

jgsogo commented Sep 7, 2021

This is the output I can get: https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/5542/72-production/libigl/2.3.0//summary.json

In that last run, only the Linux jobs were pending (UNKNOWN), this is why I think it is something related to Linux... I don't have the numbers about how long it was running for Linux, but it was hours so probably something was going wrong with it. All of them are DEBUG builds, so probably it is just those builds that require much more memory.

@AndreyMlashkin
Copy link
Contributor Author

So, there are no any build logs or something?

@jgsogo
Copy link
Contributor

jgsogo commented Sep 7, 2021

So, there are no any build logs or something?

When a POD crashes, we are not able to get the log (we could use other strategies, ping @davidsanfal ). The log is written to a file and then uploaded. If the process is killed it will be lost together with the POD.

@AndreyMlashkin
Copy link
Contributor Author

You could write a file to some shared volume :)

@conan-center-bot
Copy link
Collaborator

All green in build 73 (6675244a0f16e20061e33b38df8cf0c3c9ffeafa):

  • libigl/2.3.0@:
    All packages built successfully! (All logs)

@AndreyMlashkin
Copy link
Contributor Author

I have left only header-only option.
Once it is merged, I will create another PR, removing the check

@AndreyMlashkin
Copy link
Contributor Author

@SSE4 @uilianries @jgsogo, please approve

@jgsogo jgsogo removed the infrastructure Waiting on tools or services belonging to the infra label Sep 10, 2021
@conan-center-bot conan-center-bot merged commit 63729e6 into conan-io:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] libigl/2.2.0
6 participants