Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow libigl to be built as lib #7238

Merged

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Sep 10, 2021

Specify library name and version: libigl/2.3.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@AndreyMlashkin
Copy link
Contributor Author

Relates to #5542

@conan-center-bot
Copy link
Collaborator

All green in build 1 (3ceaa246b698eed712c57a9bc143138536346466):

  • libigl/2.3.0@:
    All packages built successfully! (All logs)

@AndreyMlashkin
Copy link
Contributor Author

@jgsogo , there is no build with header_only=False, there are only five that are explicitly set it to True (which is default) and therefore marked as duplicated

@jgsogo
Copy link
Contributor

jgsogo commented Sep 10, 2021

@jgsogo , there is no build with header_only=False, there are only five that are explicitly set it to True (which is default) and therefore marked as duplicated

This is how it works: the CI adds another configuration with header_only=True if the option header_only is available in the recipe. So, if header_only=True is already the default, it will add that new configuration, but it will be already duplicated.

Use default header_only=False and it will generate all the configurations and it will add one more with header_only=True.

@Croydon
Copy link
Contributor

Croydon commented Sep 12, 2021

This is how it works: the CI adds another configuration with header_only=True if the option header_only is available in the recipe. So, if header_only=True is already the default, it will add that new configuration, but it will be already duplicated.

Use default header_only=False and it will generate all the configurations and it will add one more with header_only=True.

Is that something that CCI could improve? Adding header_only=False when header_only is True by default? Feels like an unnecessary restriction

-> #7267

@conan-center-bot conan-center-bot merged commit 2235397 into conan-io:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants