-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny Changes for Fast-DDS + Add version 2.3.3 #6429
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -174,7 +174,8 @@ def package_info(self): | |||||
self.cpp_info.names["cmake_find_package"] = "fastdds" | ||||||
self.cpp_info.names["cmake_find_multi_package"] = "fastdds" | ||||||
# component fastrtps | ||||||
self.cpp_info.components["fastrtps"].name = "fastrtps" | ||||||
self.cpp_info.components["fastrtps"].names["cmake_find_package"] = "fastrtps" | ||||||
self.cpp_info.components["fastrtps"].names["cmake_find_multi_package"] = "fastrtps" | ||||||
self.cpp_info.components["fastrtps"].libs = tools.collect_libs(self) | ||||||
self.cpp_info.components["fastrtps"].requires = [ | ||||||
"fast-cdr::fast-cdr", | ||||||
|
@@ -197,13 +198,15 @@ def package_info(self): | |||||
self.cpp_info.components["fastrtps"].build_modules["cmake_find_package"] = [self._module_file_rel_path] | ||||||
self.cpp_info.components["fastrtps"].build_modules["cmake_find_package_multi"] = [self._module_file_rel_path] | ||||||
# component fast-discovery | ||||||
self.cpp_info.components["fast-discovery"].name = "fast-discovery" | ||||||
self.cpp_info.components["fast-discovery"].bindirs = ["bin"] | ||||||
self.cpp_info.components["fast-discovery-server"].names["cmake_find_package"] = "fast-discovery-server" | ||||||
self.cpp_info.components["fast-discovery-server"].names["cmake_find_multi_package"] = "fast-discovery-server" | ||||||
self.cpp_info.components["fast-discovery-server"].bindirs = ["bin"] | ||||||
bin_path = os.path.join(self.package_folder, "bin") | ||||||
self.output.info("Appending PATH env var for fast-dds::fast-discovery with : {}".format(bin_path)), | ||||||
self.output.info("Appending PATH env var for fast-dds::fast-discovery-server with : {}".format(bin_path)), | ||||||
self.env_info.PATH.append(bin_path) | ||||||
# component tools | ||||||
self.cpp_info.components["tools"].name = "tools" | ||||||
self.cpp_info.components["tools"].names["cmake_find_package"] = "tools" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The name here is a little generic... maybe?
Suggested change
|
||||||
self.cpp_info.components["tools"].names["cmake_find_multi_package"] = "tools" | ||||||
self.cpp_info.components["tools"].bindirs = [os.path.join("bin","tools")] | ||||||
bin_path = os.path.join(self._pkg_bin, "tools") | ||||||
self.output.info("Appending PATH env var for fast-dds::tools with : {}".format(bin_path)), | ||||||
|
28 changes: 28 additions & 0 deletions
28
recipes/fast-dds/all/patches/2.3.3-0001-fix-find-asio-and-tinyxml2.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 8a9cb0209..400c681e7 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -225,8 +225,8 @@ if(NOT BUILD_SHARED_LIBS) | ||
endif() | ||
|
||
eprosima_find_package(fastcdr REQUIRED) | ||
-eprosima_find_thirdparty(Asio asio VERSION 1.10.8) | ||
-eprosima_find_thirdparty(TinyXML2 tinyxml2) | ||
+eprosima_find_thirdparty(asio REQUIRED) | ||
+eprosima_find_thirdparty(tinyxml2 REQUIRED) | ||
|
||
find_package(foonathan_memory REQUIRED) | ||
message(STATUS "Found foonathan_memory: ${foonathan_memory_DIR}") | ||
diff --git a/src/cpp/CMakeLists.txt b/src/cpp/CMakeLists.txt | ||
index d26915242..f00e36ea6 100644 | ||
--- a/src/cpp/CMakeLists.txt | ||
+++ b/src/cpp/CMakeLists.txt | ||
@@ -456,7 +456,7 @@ elseif(NOT EPROSIMA_INSTALLER) | ||
# Link library to external libraries. | ||
target_link_libraries(${PROJECT_NAME} ${PRIVACY} fastcdr foonathan_memory | ||
${CMAKE_THREAD_LIBS_INIT} ${CMAKE_DL_LIBS} | ||
- ${TINYXML2_LIBRARY} | ||
+ tinyxml2::tinyxml2 | ||
$<$<BOOL:${LINK_SSL}>:OpenSSL::SSL$<SEMICOLON>OpenSSL::Crypto$<$<BOOL:${WIN32}>:$<SEMICOLON>crypt32.lib>> | ||
$<$<BOOL:${WIN32}>:iphlpapi$<SEMICOLON>Shlwapi> | ||
${THIRDPARTY_BOOST_LINK_LIBS} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
versions: | ||
"2.3.2": | ||
folder: all | ||
"2.3.3": | ||
folder: all |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what is here official process - 2.3.3 dont need patch - so i just gave the base_path but not the patch_file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, didn't know that works. Nice hack.
Anyway, the normal/official way is to don't add the version in patches and do the following in
conanfile.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for info - but i found out i have to patch again - i was missing my checks inside container .... so it took tinyxml from system .... so still have to add patch. ^^'