-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for linux/arm64 and darwin/arm64 #103
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
linux/arm64
and darwin/arm64
linux/arm64
and darwin/arm64
@Volatus, I tried to do architecture migration in #102. It may be more successful to comment there, though you are welcome to see if you can make more headway here. You need to add several things to the build sections of the builds as in: |
@xylar thanks for the pointers, I'll see what I can do |
0ac0d77
to
ae30c27
Compare
@conda-forge-admin, please rerender |
77b3268
to
997817e
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
997817e
to
a1bd820
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/airflow-feedstock/actions/runs/4404255160. |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/airflow-feedstock/actions/runs/4404263799. |
@xylar It seems like some issue with |
I asked about it here: |
Right, and I thought Airflow broke something recently but it did seem like yarn worked fine for me locally on their repo. How would I try running a local build of this feedstock for my host and arch to test some things? |
Hmm, I don't think Airflow changed but it does seem like some of the yarn dependencies aren't working anymore. We probably need to figure out how to patch
If you can install docker, you can use:
That's not foolproof (it can pick up system libraries occasionally) but works pretty well. |
You will need to install mamba and boa for this. boa provides mambabuild. I believe there are currently some compatibility issues with the latest conda, mamba and boa so it might be safest to go with a version of conda from earlier this year so that you can have a working installation of conda and boa. (Very inconvenient, so I hope it gets worked out soon!) |
@Volatus, it looks like there is a release candidate for 2.5.2: |
@Volatus, if you rebase, you should be able to test again. The fix was to constrain |
11a0632
to
a1cff27
Compare
@xylar So here's the takeaways:
|
@Volatus, okay, we could wait on OSX-ARM for now (and make a separate PR where we ask for help from the experts). Regarding aarch64, I don't think there's anything we can do about updating |
I was wondering how I can change the Docker image for the |
It probably makes sense to skip this test when we're cross-compiling: airflow-feedstock/recipe/meta.yaml Line 114 in a1cff27
|
I don't think we have the ability to change the docker images. That has to be done consistently across feedstocks by the conda-forge/core folks. |
Signed-off-by: Ismayil Mirzali <[email protected]>
a1cff27
to
e433f7b
Compare
@Volatus, I solved the OSX ARM issue by moving two of the package from host (target architecture) to build (native architecture). That got merged in #106 and should be available soon (if not now). I'm working on the Linux architectures in #105 but certainly am open to suggestions you might have. Feel free to keep working here if you need a testing grounds. |
Signed-off-by: Ismayil Mirzali [email protected]
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)closes #101