Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.5.0rc0 #233

Closed
wants to merge 21 commits into from
Closed

Release 4.5.0rc0 #233

wants to merge 21 commits into from

Conversation

muhammadhamzasajjad
Copy link
Contributor

@muhammadhamzasajjad muhammadhamzasajjad commented Jun 24, 2024 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: build: numpy < 2 should not contain a space between relational operator and the version, i.e. numpy <2
  • requirements: run: msgpack-python >= 0.5.0 should not contain a space between relational operator and the version, i.e. msgpack-python >=0.5.0

@muhammadhamzasajjad
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/arcticdb-feedstock/actions/runs/9643285412.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: run: msgpack-python >= 0.5.0 should not contain a space between relational operator and the version, i.e. msgpack-python >=0.5.0

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@muhammadhamzasajjad
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/arcticdb-feedstock/actions/runs/9643347218.

@muhammadhamzasajjad muhammadhamzasajjad self-assigned this Jun 24, 2024
jamesmunro
jamesmunro reviewed Jun 24, 2024
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@jjerphan jjerphan mentioned this pull request Jun 24, 2024
Closed
@muhammadhamzasajjad
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@muhammadhamzasajjad
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits June 24, 2024 15:05
MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.36.2, and co…
c8885f0 
…nda-forge-pinning 2024.06.24.14.05.35
@jjerphan
Add libboost as a host dependency
3a081e6 
It is present since other library pulls it,
but it must also be listed as a dependency
here to explicitly make sure it is present
at runtime.

Signed-off-by: Julien Jerphanion <[email protected]>
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

@jjerphan
Use libboost-devel instead
04e1121 
Signed-off-by: Julien Jerphanion <[email protected]>
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/arcticdb-feedstock/actions/runs/9665383122.

@muhammadhamzasajjad
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/arcticdb-feedstock/actions/runs/9665482158.

@muhammadhamzasajjad muhammadhamzasajjad mentioned this pull request Jun 25, 2024
Closed
5 tasks
@jjerphan
Copy link
Member

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjerphan
Copy link
Member

@conda-forge-admin, please rerender

@jjerphan jjerphan marked this pull request as draft June 26, 2024 10:40
@jjerphan jjerphan mentioned this pull request Jun 26, 2024
Merged
5 tasks
@jjerphan jjerphan mentioned this pull request Jun 28, 2024
Merged
5 tasks
@jjerphan
Copy link
Member

Closing since #242 has been merged.

@jjerphan jjerphan closed this Jun 28, 2024
@jjerphan jjerphan mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmunro jamesmunro jamesmunro left review comments

@jjerphan jjerphan jjerphan left review comments

@DerThorsten DerThorsten Awaiting requested review from DerThorsten DerThorsten is a code owner

@G-D-Petrov G-D-Petrov Awaiting requested review from G-D-Petrov G-D-Petrov is a code owner

@Hind-M Hind-M Awaiting requested review from Hind-M Hind-M is a code owner

@JohanMabille JohanMabille Awaiting requested review from JohanMabille JohanMabille is a code owner

@Klaim Klaim Awaiting requested review from Klaim Klaim is a code owner

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 is a code owner

@joe-iddon joe-iddon Awaiting requested review from joe-iddon joe-iddon is a code owner

@mehertz mehertz Awaiting requested review from mehertz mehertz is a code owner

@phoebusm phoebusm Awaiting requested review from phoebusm phoebusm is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars is a code owner

@qc00 qc00 Awaiting requested review from qc00 qc00 is a code owner

@vasil-pashov vasil-pashov Awaiting requested review from vasil-pashov vasil-pashov is a code owner

Assignees

@muhammadhamzasajjad muhammadhamzasajjad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhammadhamzasajjad @jjerphan @jamesmunro