Reduce memory usage during conda build #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
added a commit
to muhammadhamzasajjad/arcticdb-feedstock
that referenced
this pull request
Jun 26, 2024
Signed-off-by: Julien Jerphanion <[email protected]>
muhammadhamzasajjad
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
jjerphan
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
LGTM, after checking that this patch allows making the builds pass on the feedstock by applying it on top of conda-forge/arcticdb-feedstock#233 (e.g. see those logs).
Thank you, @muhammadhamzasajjad.
poodlewars
approved these changes
Jun 26, 2024
muhammadhamzasajjad
added a commit
that referenced
this pull request
Jun 28, 2024
Add more translation units for binary operators to reduce memory usage. The build on conda was failing in arcticdb-feedstock as it was using a lot of memory. The feedstock runners only have `6.7GB` of RAM. Splitting the binary operators in multiple translation units reduces memory usage and fixes the issue. The issue was also observed in ArcticDB CI. #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more translation units for binary operators to reduce memory usage.
The build on conda was failing in arcticdb-feedstock as it was using a lot of memory. The feedstock runner only have
6.7GBof RAM. Splitting the binary operators in multiple translation units reduces memory usage and fixes the issue.What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...