Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MKL to 2022.0 build #81

Merged
merged 6 commits into from
Jan 19, 2022
Merged

Conversation

haasad
Copy link
Member

@haasad haasad commented Jan 12, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Update to latest MKL: conda-forge/intel_repack-feedstock#32

@h-vetinari I saw that you're also working on supporting blas 3.9.1 and blas 3.10, but according to conda-forge/intel_repack-feedstock#32 (comment) mkl 2022.0 doesn't yet support them.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@haasad
Copy link
Member Author

haasad commented Jan 12, 2022

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member

This will probably need a conda_build_config.yaml with the following content (+ a rerender):

mkl:        # [win]
  - '2021'  # [win]
mkl_devel:  # [win]
  - '2021'  # [win]

This is because the global pinning puts mkl at 2021, and when the unpinned mkl gets added for blas-devel (through the pinning), it conflicts with the rest of the recipe.

Alternatively (and arguably the better solution) is to just parametrize the mkl-version as a jinja-variable and re-use it in the blas-devel output.

@h-vetinari
Copy link
Member

This will also need to be rebased & rerendered after #82.

@haasad
Copy link
Member Author

haasad commented Jan 13, 2022

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/blas-feedstock/actions/runs/1693832693.

@isuruf
Copy link
Member

isuruf commented Jan 19, 2022

@conda-forge-admin, rerender

@isuruf isuruf merged commit 064c846 into conda-forge:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants