-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accelerate backend with newer lapack from netlib #82
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, you're replacing the accelerate LAPACK with the netlib one, but leaving accelerate to provide the BLAS implementation, passed through the shim layer of https://github.com/mcg1969/vecLibFort, right?
Thanks for reminding me elsewhere that the ancient accelerate LAPACK version is the biggest issue with this, so from that POV, this plan makes sense. Netlib LAPACK will be quite slow though - any reason we shouldn't couple it with openblas (I guess the same question would go for blis)?
No, it's not. Netlib LAPACK's performance depends on the underlying BLAS performance. OpenBLAS's LAPACK is basically Netlib's LAPACK with only a dozen functions that are optimized. (We use Accelerate's version for those dozen functions) |
Makes sense, thanks. Wasn't aware that LAPACK apparently just pieces together BLAS functions, I had thought that there were (more) separate functions... |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)