Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Re-rendered with conda-build 3.23.1, conda-smithy 3.22.0.gh_1699… #189

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

mbargull
Copy link
Member

@mbargull mbargull commented Dec 2, 2022

…, and conda-forge-pinning 2022.12.02.15.22.41

Re-rendered with conda-smithy 3.22.0 patched with
conda-forge/conda-smithy#1699

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Trying to fix uploads for Windows builds. Follow-up to gh-181 and gh-186 .

…, and conda-forge-pinning 2022.12.02.15.22.41

Re-rendered with conda-smithy 3.22.0 patched with
conda-forge/conda-smithy#1699
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Would suggest we push this to a branch on the feedstock once CI passes. That way we can see if it is working or not (since we are checking whether uploads work).

Longer term we might want to think about how we can reproduce the step that failed as part of the build without needing to upload (IOW running whatever verification is being run).

@mbargull
Copy link
Member Author

mbargull commented Dec 2, 2022

Would suggest we push this to a branch on the feedstock once CI passes. That way we can see if it is working or not (since we are checking whether uploads work).

The main branch is a good as any for that.. (At least we have the commit from which packages were built in its history then.)

@mbargull mbargull merged commit 4472f97 into conda-forge:main Dec 2, 2022
@jakirkham
Copy link
Member

Sure no problem with merging. Just if there are issues, we need to create more PRs potentially. Trying to save us extra churn, but no strong feelings either way.

@jakirkham
Copy link
Member

Looks like one of the Windows builds worked! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants