Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: rerender #8

Merged
merged 6 commits into from
Dec 6, 2022
Merged

MNT: rerender #8

merged 6 commits into from
Dec 6, 2022

Conversation

conda-forge-linter
Copy link

@conda-forge-linter conda-forge-linter commented Dec 6, 2022 •
edited by jakirkham
Loading

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #7.

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #5
Fixes #7

@conda-forge-linter conda-forge-linter mentioned this pull request Dec 6, 2022
Closed
@conda-forge-linter
Copy link
Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 2 commits December 6, 2022 08:41
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

jakirkham
jakirkham reviewed Dec 6, 2022
View reviewed changes
.azure-pipelines/azure-pipelines-win.yml
Comment on lines +104 to +106
set "TEMP=$(UPLOAD_TEMP)"
if not exist "%TEMP%\" md "%TEMP%"
set "TMP=%TEMP%"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently came up with this workaround to release conda ( conda-forge/conda-feedstock#189 ), which ran into a similar issue as this feedstock. Maybe it will work to address the issue seen here as well

@jakirkham jakirkham mentioned this pull request Dec 6, 2022
Closed
1 task
@jakirkham
Copy link
Member

Appears we are now seeing a solver error on Linux?

RuntimeError: Solver could not find solution.Mamba failed to solve:
 - go >=1.18
 - make
 - go-licenses
 - go-cgo >=1.18
 - gcc_linux-64 11.*

with channels:

The reported errors are:
- Encountered problems while solving:
-   - package go-cgo-1.18.3-hc2a3312_0 requires go 1.18.3 h5acc617_0, but none of the providers can be installed

More details in this CI job (log attached).

@jakirkham
Revert to GCC 10
080cfb8 
GCC 11 has solver issues with Go. So revert to GCC 10.
jakirkham
jakirkham reviewed Dec 6, 2022
View reviewed changes
recipe/conda_build_config.yaml
Comment on lines +10 to +11
c_compiler_version:
- "10" # [linux]
Copy link
Member

@jakirkham jakirkham Dec 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears GCC 11 can't be installed with Go. So pinning to GCC 10 for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised issue ( #10 ) to revert

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 6, 2022

Welp, it's building: let's merge and see what happens!

@bollwyvl bollwyvl merged commit 81ad90e into conda-forge:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@bollwyvl bollwyvl Awaiting requested review from bollwyvl bollwyvl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please re-render kubo 0.17 windows not uploading
4 participants
@conda-forge-linter @jakirkham @bollwyvl @conda-forge-admin