-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require ruamel.yaml #81
Conversation
Rebuild the package now that `ruamel.yaml` is required instead of `ruamel_yaml`.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This likely needs a tighter upper bound as conda has issues with later versions of the ruamel.yaml 0.15.x series. I believe 0.15.64 works but 0.15.87 breaks some tests. |
Does 0.15.88 and 0.15.89 also break tests or was it just 0.15.87? |
I have not tested 0.15.88/89 or really anything between 0.15.64 and 0.15.87. The safest bet would be the make the upper bound <=0.15.64. A new build could relax this once a more precise upper bound is known. I will have some time next week to test the various newer versions and hopefully fix the issues in conda around them. |
Thanks @jjhelmus. That would be very helpful :) |
Can this be closed? |
Nope. This still needs to be done. Just haven't had time of late. Feel free to push on it if you do. 🙂 |
What is the current state of this? It would be great to merge this. |
That's a great question. I don't know. Would also be happy to see this merged. @jjhelmus raised some concerns about |
AFAIK conda can use either Investigation into compatible versions and updating conda so it works with the latest would be wonderful. |
It would be good to understand why Conda is sensitive so we can mitigate this (or at least raise issues upstream) to improve stability. |
Yep, However, please consider conda-forge/ruamel.yaml-feedstock#119 (comment) prior to this. This will affect
Doing a quick |
Thanks for putting all that info together @mbargull ! |
So is this OK to merge? |
Not yet. Things to do:
Re 2.: The given solutions are not "optimal" (the one I prefer involves metadata patching which I normally shy away from, for good reasons). I would like us to reach consensus on that issue before making |
Thanks Jannis! 🙏 Nice to see this resolved 😄 |
Switches to requiring
ruamel.yaml
instead ofruamel_yaml
.cc @jjhelmus
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)