Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64 and ppc64le #52

Merged
merged 4 commits into from
Mar 13, 2019
Merged

aarch64 and ppc64le #52

merged 4 commits into from
Mar 13, 2019

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Mar 13, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

We were discussing moving to ruamel.yaml for conda. ( conda-forge/conda-feedstock#81 ) That said, feel free to go ahead with this short-term if it helps move things forward.

@isuruf
Copy link
Member Author

isuruf commented Mar 13, 2019

Merging for now to get this going

@isuruf isuruf merged commit 1aa8a12 into conda-forge:master Mar 13, 2019
@isuruf isuruf deleted the arch branch March 13, 2019 05:51
@@ -15,6 +15,7 @@
assert ver_string == ruamel_yaml.__version__


"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, looks like there was an unannounced breaking change in conda/conda@86cb184#diff-aa5c1e6732e4802903e91fe909341fd0L380.
Fixing the test is as simple as

-check_call('conda config --add channels _test_channel_'.split(), env=env)
+check_call('conda config --add channels _test_channel_'.split() + ['--file={}'.format(condarc_path)], env=env)

It's still ugly to have these tests here, though, of course.
We should revisit the downstream testing thing. But I don't know how that handles chicken-egg-problems, e.g., testing ruamel{.,_}yaml built for python=3.8 when conda isn't yet available for that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants