-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow uploading on main channel for v1 recipes #337
feat: allow uploading on main channel for v1 recipes #337
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to wait a bit imho for the dust to settle on the linter. There are a few PRs left. Also the bot is not yet finished, which might break things.
Hey ! Thanks for the review! Can we make an actionable plan for linter work? Regarding the bot work- can it block us from allowing us to upload on the main channel? I think that even we break things we do it on bot side, uploaded packages are not affected? Do you have something on your mind how we can achieve this? |
It depends on how the bot breaks. If people convert feedstocks that need ABI migrations or version migrations, we'll break more than just a single feedstock. Things that affect the whole ecosystem like this have to move slowly enough for folks to adapt. |
@beckermr I completely understand where you are coming from but I feel the issue of packages not being uploaded is a bit of a chicken-and-egg problem. We have already had people (in the chat) wanting to convert their feedstock but holding off because the packages would not get uploaded. That makes it hard for the dust to settle. I know @jaimergp also had different ideas about this. From my perspective, these are the issues that are left open: conda-smithy:
bot:
Am I missing issues or pull-requests? edit: These items have either been deemed not needed or done in other places. |
The ABI migrations run mini migrators on top of the recipes. We'll need to merge the prs to skip those or make them work on the new format. |
Is there already an issue for this so we can keep track of it? |
On the bot repo it is issues 2918 2920 and 2924 |
Thanks I updated the overview. 👍 |
Another issue is that the solver checks repo does not currently work for v1 recipes: regro/conda-forge-feedstock-check-solvable#54 Do we have a tracking issue on the website repo for this? If not we should. |
Some smaller progress was made wrt to the CODEOWNERS file - a change in rattler-build-conda-compat should have made it work. |
I bumped the version to |
@conda-forge/core shall we go ahead with this? I am a +1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am in favor of trying this
Would suggest we do this on a non-weekend adjacent day (so not Monday or Friday). For example we could do this tomorrow (Thursday morning) or some time next week (Tuesday or later). Mention this as most people likely don't want to spend their weekends debugging and fixing issues. So picking some time where people will be around and ready to work on issues would be best
I'm around for the next four hours so I'll merge this now and watch things on the heroku server. |
Sounds good. Thanks Matt and thanks everyone working on this upgrade! 🙏 |
Noticed the
Do we need to bootstrap this change somehow (wait for native builds and restart)? Or is there something missing in those cases? |
That appears to be a cross-python issue unrelated to this package, right? cc @conda-forge/core @conda-forge/cross-python |
Yeah came to the same conclusion That package has this logic in its activation script: $BUILD_PREFIX/bin/python -m crossenv $PREFIX/bin/python \
--sysroot $CONDA_BUILD_SYSROOT \
--without-pip $BUILD_PREFIX/venv \
--sysconfigdata-file "$sysconfigdata_fn" \
--machine ${machine} \
--cc ${CC:-@CC@} \
--cxx ${CXX:-@CXX@} Am guessing |
We don't build with rattler build in ci-setup, so it is something else. |
AFAIK we don't set Note this error happens for the CPU-only ARM/PPC builds here (not CUDA ones). In case that provides any clues Separately: Maybe we should switch |
I get the same error with 24.7.1 |
Something shipped today broke everything. The CI ran fine this morning. |
Could this be related ( conda-forge/binutils-feedstock#76 )? |
Discussion continues in PR: #349 |
In any event, think we agree this is not related to the changes in this PR. Just external changes that are now affecting Given that, decided to kick the tires on this change. Recently, while I was out, my colleagues added a brand new feedstock Also have started a fresh build of |
This unfortunately failed. Though for reasons that appear to have to do with that feedstock itself Am guessing it just needs PR ( conda-forge/jolt-physics-feedstock#2 ) to fix it |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)now that we have implemented all rattler-build lints checks and we have a working feedstock: https://github.com/conda-forge/jolt-physics-feedstock
I would like to uplift restrictions of uploading rattler-build to main channel.
Should be merged after release of: conda-forge/conda-smithy#2037