-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add torchaudio #27715
add torchaudio #27715
Conversation
Trying to revamp #17082 |
Hi! This is the friendly automated conda-forge-linting service. I Failed to even lint the recipe, probably because of a conda-smithy This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11267788945. |
@conda-forge/help-c-cpp ready for review |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
@hmaarrfk LGTM for me, but please let me know if you think something is missing. |
Looks fine, but to be honest, I'm not sure on where we stand with rattler recipes. Are we accepting them yet? or just building out infrastructure for them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up again! Looks quite good, but I want to see how the tests are doing, at least a reasonable subset.
recipes/torchaudio/recipe.yaml
Outdated
script: | ||
# remove example tests that are not importable out-of-tree | ||
# - rm -rf test/torchaudio_unittest/example | ||
# - CI=true pytest -v test/ | ||
|
||
# Note: Tests take too long to run and some are not importable out-of-tree | ||
- echo "Hello World" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see some result of running the test suite (and efforts to get it to run) before we decide to skip it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enabled them, let's see what happens.
Yes we are (as of conda-forge/conda-forge-ci-setup-feedstock#337). There's a few already |
I think this is finally ready for review :) @hadim: Could you please remove the Draft label from the PR? |
Note that cuda 11.8 failed with "No space left on device (os error 28)" which will not be an issue once it's converted to a feedstock with separate builds. |
Thanks @hmaarrfk for the review! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).