Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add torchaudio #27715

Merged
merged 70 commits into from
Oct 13, 2024
Merged

add torchaudio #27715

merged 70 commits into from
Oct 13, 2024

Conversation

hadim
Copy link
Member

@hadim hadim commented Sep 28, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@hadim
Copy link
Member Author

hadim commented Sep 28, 2024

Trying to revamp #17082

Copy link

github-actions bot commented Sep 28, 2024

Hi! This is the friendly automated conda-forge-linting service.

I Failed to even lint the recipe, probably because of a conda-smithy
bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11267788945.

@hadim
Copy link
Member Author

hadim commented Sep 28, 2024

@conda-forge/help-c-cpp ready for review

@hadim hadim mentioned this pull request Sep 30, 2024
6 tasks
Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@hadim
Copy link
Member Author

hadim commented Sep 30, 2024

@hmaarrfk LGTM for me, but please let me know if you think something is missing.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Oct 1, 2024

Looks fine, but to be honest, I'm not sure on where we stand with rattler recipes. Are we accepting them yet? or just building out infrastructure for them?

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up again! Looks quite good, but I want to see how the tests are doing, at least a reasonable subset.

Comment on lines 148 to 154
script:
# remove example tests that are not importable out-of-tree
# - rm -rf test/torchaudio_unittest/example
# - CI=true pytest -v test/

# Note: Tests take too long to run and some are not importable out-of-tree
- echo "Hello World"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see some result of running the test suite (and efforts to get it to run) before we decide to skip it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enabled them, let's see what happens.

@h-vetinari
Copy link
Member

Looks fine, but to be honest, I'm not sure on where we stand with rattler recipes. Are we accepting them yet?

Yes we are (as of conda-forge/conda-forge-ci-setup-feedstock#337). There's a few already

recipes/torchaudio/recipe.yaml Outdated Show resolved Hide resolved
@hadim hadim marked this pull request as draft October 2, 2024 19:45
@Tobias-Fischer
Copy link
Contributor

I think this is finally ready for review :)

@hadim: Could you please remove the Draft label from the PR?

@hadim hadim marked this pull request as ready for review October 10, 2024 02:04
@Tobias-Fischer
Copy link
Contributor

Note that cuda 11.8 failed with "No space left on device (os error 28)" which will not be an issue once it's converted to a feedstock with separate builds.

@hmaarrfk hmaarrfk merged commit 976b48d into conda-forge:main Oct 13, 2024
6 of 9 checks passed
@Tobias-Fischer Tobias-Fischer deleted the torchaudio branch October 13, 2024 21:57
@Tobias-Fischer
Copy link
Contributor

Thanks @hmaarrfk for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants