Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to new name for libgcc #25

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

h-vetinari
Copy link
Member

Following conda-forge/ctng-compilers-feedstock#148, which finished up a long-open transition. The old naming still exists as a wrapper, but it would be better not to depend on it anymore. We should also backport this to 12.0

@h-vetinari h-vetinari requested a review from a team as a code owner August 28, 2024 07:18
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@billysuh7
Copy link
Contributor

LGTM @h-vetinari . I guess by virtue of libgcc being added to ignore_list for run_exports, we are all good going forward, correct?

@h-vetinari
Copy link
Member Author

I guess by virtue of libgcc being added to ignore_list for run_exports, we are all good going forward, correct?

Which ignore-list are you talking about? 🤔

There's nothing in this PR or on main.

@billysuh7
Copy link
Contributor

I guess by virtue of libgcc being added to ignore_list for run_exports, we are all good going forward, correct?

Which ignore-list are you talking about? 🤔

There's nothing in this PR or on main.

Oh sorry, I was referring to conda/conda-build#5475 (comment) where they ended up adding libgcc to the ignore list for being exported so I thought this was why we could just remove -ng as we did in this case and not have to employ a workaround like ignore_run_exports_from as mentioned in the continuing discussion in that thread. Please let me know if I misunderstand this thing. Thanks!

@h-vetinari
Copy link
Member Author

Please let me know if I misunderstand this thing.

The conda-build discussion doesn't really apply to individual feedstocks; here you'll see in the link check whether this is used or not, but libgcc is so ubiquitous on linux (basically in every environment) that it doesn't really matter if you ignore it; you'll get it in the final environment anyway. The logs on azure have been deleted in the meantime, so let's refresh.

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@billysuh7 billysuh7 merged commit 661e763 into conda-forge:main Oct 30, 2024
6 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@h-vetinari h-vetinari deleted the no_ng branch October 30, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants