-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rdma-core
package (instead of CDT) & add to linux_aarch64
#14
Conversation
Also include on `linux_aarch64` as it uses this dependency too.
…nda-forge-pinning 2024.03.12.14.44.34
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Not seeing Azure here. Going to try restarting @conda-forge-admin , please restart CI |
Looks like that fixed it |
Am seeing the following on CI
Based on looking locally, this appears to be happening because libcufile-feedstock/recipe/build.sh Line 10 in 7f8e1ec
IOW this looks like a bug in |
@conda-forge-admin , please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like I wasn't able to push to the drop_cdt branch of jakirkham-feedstocks/libcufile-feedstock. Did you check the "Allow edits from maintainers" box? NOTE: Our webservices cannot push to PRs from organization accounts or PRs from forks made from organization forks because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libcufile-feedstock/actions/runs/8626284824. |
…nda-forge-pinning 2024.04.10.04.46.28
@conda-forge-admin , please re-render |
@conda-forge-admin , please lint |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin , please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libcufile-feedstock/actions/runs/8626433350. |
I'm not sure the One example from the 12.4.1 build log I see:
And here I see:
|
@conda-forge-admin , please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like I wasn't able to push to the drop_cdt branch of jakirkham-feedstocks/libcufile-feedstock. Did you check the "Allow edits from maintainers" box? NOTE: Our webservices cannot push to PRs from organization accounts or PRs from forks made from organization forks because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libcufile-feedstock/actions/runs/9654546805. |
It seems the rerendering failed 😅 |
…nda-forge-pinning 2024.06.25.03.09.40
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Not sure why it wouldn't find the libraries, they are all there
|
I seem to recall we encountered a similar situation elsewhere (but can't find the example now), where a CTK component in |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Looks like we need
However that is already here libcufile-feedstock/recipe/meta.yaml Line 161 in 63ee783
Or an RPATH fix? |
Yeah it looks like there is something up with the
As there is already libcufile-feedstock/recipe/meta.yaml Line 164 in 6b64cd2
|
Yep, this is related to issue: conda-forge/cuda-feedstock#10 |
@conda-forge-admin , please restart CI |
@conda-forge-admin, please restart ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I forgot @h-vetinari to approve this. LGTM.
Thanks Billy! 🙏 Were you meaning PR: conda-forge/cuda-nvcc-impl-feedstock#25 ? |
That is all set also, I approved it and put more comment. Thanks. |
Thanks Billy! 🙏 |
The conclusion Billy and I reached after looking into the warnings above more closely is there is likely a remaining RPATH issue in this package, which we will need to look into. This will be follow up work |
Part of issue: conda-forge/cuda-feedstock#28
Previously we used the CDT for
rdma-core
. However it would be better to use the package. Especially so as this CDT is not provided on AlmaLinux 8. This makes that change. It is also aligned with how we userdma-core
elsewhere.Additionally it looks like
rdma-core
would be needed onlinux_aarch64
, but we didn't have it there before. So this makes sure to add it.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)