-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using conda-forge's tzdata on all platforms #11
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
9783a6e
to
c2e7126
Compare
ff4b354
to
bd4cd30
Compare
@jjerphan I have tested that this works in the sparrow tests on both Windows and Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
skip: true # [win and vc<14] | ||
|
||
requirements: | ||
build: | ||
- {{ compiler('cxx') }} | ||
- {{ stdlib('c') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not work when running conda-build from osx-arm platform. Happy to re-add.
skip: true # [win and vc<14] | ||
|
||
requirements: | ||
build: | ||
- {{ compiler('cxx') }} | ||
- {{ stdlib('c') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be added back, but let's do it in a dedicated PR.
With this PR
howardhinnant_date
on all platforms.howardhinnant_date
withUSE_SYSTEM_TZ_DB
set toON
on all platforms.discover_tz_dir
is patched to return the tzdata directory under the conda prefix instead of that of the system.The patches apply to windows largely come from HowardHinnant/date#611 - except that we use
dirent
to list files and directories on Windows like it is already done on Linux, making the patch smaller.