Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using conda-forge's tzdata on all platforms #11

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented May 31, 2024

With this PR

  • tzdata becomes a dependency of howardhinnant_date on all platforms.
  • we compile howardhinnant_date with USE_SYSTEM_TZ_DB set to ON on all platforms.
  • the discover_tz_dir is patched to return the tzdata directory under the conda prefix instead of that of the system.
  • the cmake file is patched to allow using this compilation option on windows.

The patches apply to windows largely come from HowardHinnant/date#611 - except that we use dirent to list files and directories on Windows like it is already done on Linux, making the patch smaller.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@SylvainCorlay
Copy link
Member Author

@jjerphan I have tested that this works in the sparrow tests on both Windows and Linux.

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

skip: true # [win and vc<14]

requirements:
build:
- {{ compiler('cxx') }}
- {{ stdlib('c') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for removing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work when running conda-build from osx-arm platform. Happy to re-add.

skip: true # [win and vc<14]

requirements:
build:
- {{ compiler('cxx') }}
- {{ stdlib('c') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added back, but let's do it in a dedicated PR.

@JohanMabille JohanMabille merged commit 809caca into conda-forge:main Jun 3, 2024
7 checks passed
@SylvainCorlay SylvainCorlay deleted the use-conda-tzdata branch June 3, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants