Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why no noarch? #24

Closed
maartenbreddels opened this issue Nov 26, 2020 · 6 comments
Closed

Why no noarch? #24

maartenbreddels opened this issue Nov 26, 2020 · 6 comments

Comments

@maartenbreddels
Copy link
Contributor

Is there a reason or should we make this noarch ?
@bollwyvl
Copy link
Contributor

#26 does (and now nothing else, as the tests thing is resolved).

A little more research reveals: if we rely on jupyter_core for the pywin32 pin, we'd want to pin to jupyter_core >=4.6.1 as that's when some of that functionality came over from jupyter_client: jupyter/jupyter_core#163

I'd feel more comfortable if that pin was moved upstream, i guess...

@bollwyvl
Copy link
Contributor

Ah, there's this: jupyter-server/jupyter_server#281

It's just a bit of a lift to pull those changes over, and indeed raise the pin. I'll do the upstream PR and close #26.

@bollwyvl
Copy link
Contributor

jupyter-server/jupyter_server#357

@bollwyvl
Copy link
Contributor

ipython/ipykernel#564

@bollwyvl bollwyvl mentioned this issue Jan 2, 2021
Merged
5 tasks
@bollwyvl bollwyvl mentioned this issue Jan 30, 2021
Merged
5 tasks
@bollwyvl bollwyvl mentioned this issue May 13, 2021
Merged
5 tasks
@bollwyvl
Copy link
Contributor

I think #58 will finally fix this. 🎉

@bollwyvl
Copy link
Contributor

Closed by #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bollwyvl @maartenbreddels