Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip py36, pip check, add maintainer #34

Merged
merged 4 commits into from
Jan 4, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 2, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Since we haven't resolve the noarch thing (#24), this uncomments the py36 skip (which may reveal some pypy thing, but we'll deal with that when we get there). Also:

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl bollwyvl mentioned this pull request Jan 2, 2021
5 tasks
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 2, 2021

Pypy builds should be up for anyio soon... will rekick this at that point:

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 2, 2021

also, tests are still sneaking in, which i thought i fixed upstream...

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 2, 2021

@conda-forge/jupyter_server ready for review!

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 4, 2021

@conda-forge/jupyter_server I'll be less available today, but checking email occasionally... it would be great to get this in before the hype machine warms up to avoid "doesn't work on py36" support issues.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 975ecd0 into conda-forge:master Jan 4, 2021
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 4, 2021 via email

@blink1073
Copy link
Member

Happy new year to you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants