Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libignition-math4 v6.9.0 #18

Merged
merged 8 commits into from
Oct 3, 2021

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1289164663, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows no discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

traversaro commented Oct 2, 2021

macOS x64 tests are now failing with:

2021-09-30T01:53:02.8737980Z [ 44%] Building CXX object src/CMakeFiles/UNIT_Plane_TEST.dir/Plane_TEST.cc.o
2021-09-30T01:53:05.0481980Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/work/src/Plane_TEST.cc:168:25: error: 'value' is unavailable: introduced in macOS 10.13
2021-09-30T01:53:05.0483210Z     EXPECT_EQ(intersect.value(), Vector3d(2, 0, 0));
2021-09-30T01:53:05.0483760Z                         ^
2021-09-30T01:53:05.0485110Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/_build_env/bin/../include/c++/v1/optional:954:27: note: 'value' has been explicitly marked unavailable here
2021-09-30T01:53:05.0485950Z     constexpr value_type& value() &
2021-09-30T01:53:05.0486530Z                           ^
2021-09-30T01:53:05.0488130Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/work/src/Plane_TEST.cc:168:25: error: 'value' is unavailable: introduced in macOS 10.13
2021-09-30T01:53:05.0489050Z     EXPECT_EQ(intersect.value(), Vector3d(2, 0, 0));
2021-09-30T01:53:05.0490140Z                         ^
2021-09-30T01:53:05.0491460Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/_build_env/bin/../include/c++/v1/optional:954:27: note: 'value' has been explicitly marked unavailable here
2021-09-30T01:53:05.0492630Z     constexpr value_type& value() &
2021-09-30T01:53:05.0493110Z                           ^
2021-09-30T01:53:05.0494390Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/work/src/Plane_TEST.cc:173:25: error: 'value' is unavailable: introduced in macOS 10.13
2021-09-30T01:53:05.0496450Z     EXPECT_EQ(intersect.value(), Vector3d(2, 2, 0));
2021-09-30T01:53:05.0497000Z                         ^
2021-09-30T01:53:05.0498340Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/_build_env/bin/../include/c++/v1/optional:954:27: note: 'value' has been explicitly marked unavailable here
2021-09-30T01:53:05.0499180Z     constexpr value_type& value() &
2021-09-30T01:53:05.0499720Z                           ^
2021-09-30T01:53:05.0500990Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/work/src/Plane_TEST.cc:173:25: error: 'value' is unavailable: introduced in macOS 10.13
2021-09-30T01:53:05.0501840Z     EXPECT_EQ(intersect.value(), Vector3d(2, 2, 0));
2021-09-30T01:53:05.0502390Z                         ^
2021-09-30T01:53:05.0503670Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/_build_env/bin/../include/c++/v1/optional:954:27: note: 'value' has been explicitly marked unavailable here
2021-09-30T01:53:05.0504780Z     constexpr value_type& value() &
2021-09-30T01:53:05.0505410Z                           ^
2021-09-30T01:53:05.0527950Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/work/src/Plane_TEST.cc:208:26: error: 'value' is unavailable: introduced in macOS 10.13
2021-09-30T01:53:05.0529010Z     EXPECT_EQ(intersect1.value(), Vector3d(0, 0, 0));
2021-09-30T01:53:05.0530010Z                          ^
2021-09-30T01:53:05.0531370Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/_build_env/bin/../include/c++/v1/optional:954:27: note: 'value' has been explicitly marked unavailable here
2021-09-30T01:53:05.0532270Z     constexpr value_type& value() &
2021-09-30T01:53:05.0532810Z                           ^
2021-09-30T01:53:05.0534070Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/work/src/Plane_TEST.cc:208:26: error: 'value' is unavailable: introduced in macOS 10.13
2021-09-30T01:53:05.0535410Z     EXPECT_EQ(intersect1.value(), Vector3d(0, 0, 0));
2021-09-30T01:53:05.0536380Z                          ^
2021-09-30T01:53:05.0537830Z /Users/runner/miniforge3/conda-bld/libignition-math6_1632966249352/_build_env/bin/../include/c++/v1/optional:954:27: note: 'value' has been explicitly marked unavailable here
2021-09-30T01:53:05.0538740Z     constexpr value_type& value() &
2021-09-30T01:53:05.0539300Z                           ^
2021-09-30T01:53:05.6451690Z 6 errors generated.

The point is that this new version of ignition-math requires a recent version of macOS SDK, while by default conda-forge tries to target an old one. As we already did for other ignition packages (see https://github.com/conda-forge/libignition-sensors-feedstock/blob/d8ab9f4638684e52c55fef0af5cf580c0bfccc8a/recipe/conda_build_config.yml), probably the easiest option is to just target a recent macOS SDK in this case.

@traversaro
Copy link
Contributor

@conda-forge-admin, please re-render.

@traversaro
Copy link
Contributor

@conda-forge-admin, please re-render.

@traversaro traversaro closed this Oct 3, 2021
@traversaro traversaro reopened this Oct 3, 2021
@traversaro
Copy link
Contributor

It seems that drone is having problems with the FAKE_INSTALL test. Not sure why this was not happening before, but again the easiest option is just to disable those testes on arm64 .

@traversaro
Copy link
Contributor

It seems that drone is having problems with the FAKE_INSTALL test. Not sure why this was not happening before, but again the easiest option is just to disable those testes on arm64 .

Related to conda-forge/libignition-physics-feedstock#14 (comment) .

@traversaro
Copy link
Contributor

It seems that drone builds are simply stuck.

@traversaro
Copy link
Contributor

It seems that drone builds are simply stuck.

Drone seems finally to be happy. Not sure if FAKE_INSTALL removal is actually necessary, but given that Drone CI is historically flaky and prone to this problems, I think we can keep it there.

@traversaro traversaro merged commit e0119e7 into conda-forge:master Oct 3, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 6.9.0_h3dde24 branch October 3, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants