Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mujoco v3.2.3 #62

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #61

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
mujoco 3.2.3 Anaconda-Server Badge

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

Failure in test:

==================================== ERRORS ====================================
____________________ ERROR collecting usd/exporter_test.py _____________________
ImportError while importing test module '$PREFIX/lib/python3.12/site-packages/mujoco/usd/exporter_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/mujoco/usd/exporter_test.py:23: in <module>
    from mujoco.usd import exporter as exporter_module  # pylint: disable=g-import-not-at-top
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/mujoco/usd/exporter.py:21: in <module>
    import mujoco.usd.camera as camera_module
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/mujoco/usd/camera.py:23: in <module>
    from pxr import Gf
E   ModuleNotFoundError: No module named 'pxr'
=========================== short test summary info ============================
ERROR usd/exporter_test.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
======================== 9 deselected, 1 error in 0.45s ========================

@traversaro
Copy link
Contributor

We do not have usdcore in conda-forge at the moment (see conda-forge/staged-recipes#16666), so we should skip usd tests for now.

@traversaro
Copy link
Contributor

We do not have usdcore in conda-forge at the moment (see conda-forge/staged-recipes#16666), so we should skip usd tests for now.

The relevant commit are google-deepmind/mujoco@85d19e1 and google-deepmind/mujoco@492cb7d .

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [257]

@conda-forge-webservices
Copy link
Contributor

conda-forge-webservices bot commented Sep 22, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

Test currently fail with:

ImportError while importing test module '$PREFIX/lib/python3.12/site-packages/mujoco/usd/exporter_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/mujoco/usd/exporter_test.py:23: in <module>
    from mujoco.usd import exporter as exporter_module  # pylint: disable=g-import-not-at-top
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/mujoco/usd/exporter.py:21: in <module>
    import mujoco.usd.camera as camera_module
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/mujoco/usd/camera.py:23: in <module>
    from pxr import Gf
E   ModuleNotFoundError: No module named 'pxr'

@traversaro
Copy link
Contributor

In the long term we should package usd in conda-forge, I started working on this in conda-forge/staged-recipes#27800 . In the short term, let's try to remove the test that import pxr.

@traversaro
Copy link
Contributor

sdflib started vendoring also spdlog, that seems dangerous, we should seriously look into unvendoring it.

@traversaro
Copy link
Contributor

sdflib started vendoring also spdlog, that seems dangerous, we should seriously look into unvendoring it.

Apparently they always vendored them: UPC-ViRVIG/SdfLib#9, I just forgot about it.

@traversaro
Copy link
Contributor

For some reason --ignore=glob=*sdf* is not working:

==================================== ERRORS ====================================
____________________ ERROR collecting usd/exporter_test.py _____________________
ImportError while importing test module '$PREFIX/lib/python3.9/site-packages/mujoco/usd/exporter_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.9/site-packages/mujoco/usd/exporter_test.py:23: in <module>
    from mujoco.usd import exporter as exporter_module  # pylint: disable=g-import-not-at-top
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.9/site-packages/mujoco/usd/exporter.py:21: in <module>
    import mujoco.usd.camera as camera_module
../_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.9/site-packages/mujoco/usd/camera.py:23: in <module>
    from pxr import Gf
E   ModuleNotFoundError: No module named 'pxr'

@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Oct 17, 2024
3 tasks
@github-actions github-actions bot closed this in #65 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants