Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64 and ppc64le #52

Merged
merged 4 commits into from
Mar 13, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions recipe/run_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
assert ver_string == ruamel_yaml.__version__


"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, looks like there was an unannounced breaking change in conda/conda@86cb184#diff-aa5c1e6732e4802903e91fe909341fd0L380.
Fixing the test is as simple as

-check_call('conda config --add channels _test_channel_'.split(), env=env)
+check_call('conda config --add channels _test_channel_'.split() + ['--file={}'.format(condarc_path)], env=env)

It's still ugly to have these tests here, though, of course.
We should revisit the downstream testing thing. But I don't know how that handles chicken-egg-problems, e.g., testing ruamel{.,_}yaml built for python=3.8 when conda isn't yet available for that...

# downstream conda config tests
import os
from os.path import join
Expand All @@ -41,3 +42,4 @@
assert b'_test_channel_' in conda_config_show_sources, conda_config_show_sources
os.remove(condarc_path)
os.rmdir(tmp_dir)
"""