Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not setting miniforge-version silently uses bundled miniconda #145

Closed
xhochy opened this issue Feb 5, 2021 · 2 comments · Fixed by #146
Closed

Not setting miniforge-version silently uses bundled miniconda #145

xhochy opened this issue Feb 5, 2021 · 2 comments · Fixed by #146
Assignees
@bollwyvl

Comments

@xhochy
Copy link
Member

xhochy commented Feb 5, 2021

If you only set miniforge-variant but not miniforge-version. The bundled miniconda is used with the current code on master.
@xhochy xhochy mentioned this issue Feb 5, 2021
Closed
@bollwyvl
Copy link
Contributor

bollwyvl commented Feb 5, 2021

Brave developer! Thanks for reporting. I have also been using master in a few places, and hadn't encountered that yet. Will get on it.

@bollwyvl bollwyvl self-assigned this Feb 5, 2021
bollwyvl added a commit to bollwyvl/setup-miniconda that referenced this issue Feb 5, 2021
@bollwyvl
remove version from win mambaforge test for conda-incubator#145
3da7dcf
@bollwyvl bollwyvl mentioned this issue Feb 5, 2021
Merged
3 tasks
@bollwyvl
Copy link
Contributor

bollwyvl commented Feb 5, 2021

Was a pretty straightforward fix over on #146!

goanpeca pushed a commit that referenced this issue Feb 5, 2021
@bollwyvl
Handle unset miniforge-version (#146)
2fc91a2 
* remove version from win mambaforge test for #145

* move miniforge-variant and -version to constants, docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bollwyvl bollwyvl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle unset miniforge-version bollwyvl/setup-miniconda
2 participants
@bollwyvl @xhochy