Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unset miniforge-version #146

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Handle unset miniforge-version #146

merged 2 commits into from
Feb 5, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 5, 2021 •
edited
Loading

Setting miniforge-variant but not setting miniforge-version doesn't use that variant.

@bollwyvl bollwyvl changed the title Handle unset miniforge-version [wip] Handle unset miniforge-version Feb 5, 2021
@bollwyvl bollwyvl changed the title [wip] Handle unset miniforge-version Handle unset miniforge-version Feb 5, 2021
@bollwyvl bollwyvl mentioned this pull request Feb 5, 2021
Closed
goanpeca
goanpeca approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround @bollwyvl :)

LGTM!

@goanpeca goanpeca merged commit 2fc91a2 into conda-incubator:master Feb 5, 2021
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 5, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goanpeca goanpeca goanpeca approved these changes

@jaimergp jaimergp Awaiting requested review from jaimergp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not setting miniforge-version silently uses bundled miniconda
2 participants
@bollwyvl @goanpeca